Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(142)

Issue 10178009: Reland 130578 - Enable cookies per default in net. Add an API to disable them by default, and do th… (Closed)

Created:
8 years, 7 months ago by jochen (gone - plz use gerrit)
Modified:
8 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Reland 130578 - Enable cookies per default in net. Add an API to disable them by default, and do that in Chrome BUG=none TEST=existing tests shouldn't break Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134524

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -4 lines) Patch
M chrome/browser/chrome_browser_main.h View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/chrome_browser_main_unittest.cc View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/service/service_main.cc View 3 chunks +6 lines, -1 line 0 comments Download
M net/url_request/url_request.h View 1 chunk +8 lines, -0 lines 0 comments Download
M net/url_request/url_request.cc View 5 chunks +15 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
jochen (gone - plz use gerrit)
Please review This is the same as https://chromiumcodereview.appspot.com/9865018 with a static bool added to ChromeBrowserMainParts ...
8 years, 7 months ago (2012-04-27 11:59:22 UTC) #1
jam
lgtm
8 years, 7 months ago (2012-04-27 15:00:16 UTC) #2
willchan no longer on Chromium
net/ changes lgtm I don't like using globals in chrome/ either, but i don't care ...
8 years, 7 months ago (2012-04-27 19:29:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10178009/1
8 years, 7 months ago (2012-04-27 19:32:20 UTC) #4
commit-bot: I haz the power
Try job failure for 10178009-1 (retry) on win_rel for step "browser_tests". It's a second try, ...
8 years, 7 months ago (2012-04-27 23:03:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jochen@chromium.org/10178009/1
8 years, 7 months ago (2012-04-30 11:46:04 UTC) #6
commit-bot: I haz the power
8 years, 7 months ago (2012-04-30 13:45:49 UTC) #7
Change committed as 134524

Powered by Google App Engine
This is Rietveld 408576698