Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(817)

Unified Diff: net/url_request/url_request.cc

Issue 10178009: Reland 130578 - Enable cookies per default in net. Add an API to disable them by default, and do th… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/url_request/url_request.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/url_request/url_request.cc
diff --git a/net/url_request/url_request.cc b/net/url_request/url_request.cc
index 8597917f0cbf49c84b3bdae3a7bebacbc264f1e0..d3fa6d1256487cdc2cd82fd9a29203b5e5b079cc 100644
--- a/net/url_request/url_request.cc
+++ b/net/url_request/url_request.cc
@@ -65,6 +65,12 @@ uint64 GenerateURLRequestIdentifier() {
return g_next_url_request_identifier++;
}
+// True once the first URLRequest was started.
+bool g_url_requests_started = false;
+
+// True if cookies are accepted by default.
+bool g_default_can_use_cookies = true;
+
} // namespace
URLRequest::ProtocolFactory*
@@ -322,6 +328,12 @@ int URLRequest::GetResponseCode() {
}
// static
+void URLRequest::SetDefaultCookiePolicyToBlock() {
+ CHECK(!g_url_requests_started);
+ g_default_can_use_cookies = false;
+}
+
+// static
bool URLRequest::IsHandledProtocol(const std::string& scheme) {
return URLRequestJobManager::GetInstance()->SupportsScheme(scheme);
}
@@ -380,6 +392,7 @@ void URLRequest::set_delegate(Delegate* delegate) {
}
void URLRequest::Start() {
+ g_url_requests_started = true;
response_info_.request_time = Time::Now();
// Only notify the delegate for the initial request.
@@ -831,7 +844,7 @@ bool URLRequest::CanGetCookies(const CookieList& cookie_list) const {
return context_->network_delegate()->NotifyReadingCookies(this,
cookie_list);
}
- return false;
+ return g_default_can_use_cookies;
}
bool URLRequest::CanSetCookie(const std::string& cookie_line,
@@ -842,7 +855,7 @@ bool URLRequest::CanSetCookie(const std::string& cookie_line,
cookie_line,
options);
}
- return false;
+ return g_default_can_use_cookies;
}
« no previous file with comments | « net/url_request/url_request.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698