Fix scaling for aura::GestureEvent and aura::TouchEvent

In High DPI mode we set transform which includes a scale factor.
Fix gesture events and touch events to scale delta and touch radius information as well

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133604

[sadrul, 2012-04-22 19:35:55]

http://codereview.chromium.org/10175002/diff/1/ui/aura/event.cc
File ui/aura/event.cc (right):

http://codereview.chromium.org/10175002/diff/1/ui/aura/event.cc#newcode471
ui/aura/event.cc:471: delta_y_ *= scale.y();
Are you sure the change here is necessary? The
pinch-scale/scroll-amount/velocity that these variables represent are usually
computed from the touch-event locations, and since the touch-event locations are
transformed properly, it is probably unnecessary to do this again here. (a test
might be useful)

[pkotwicz, 2012-04-23 00:15:40]

http://codereview.chromium.org/10175002/diff/1/ui/aura/event.cc
File ui/aura/event.cc (right):

http://codereview.chromium.org/10175002/diff/1/ui/aura/event.cc#newcode471
ui/aura/event.cc:471: delta_y_ *= scale.y();
You are right that UpdateForRootTransform is never called on GestureEvent at
present. But this can change and it would be nice for this to be correct.

[sadrul, 2012-04-23 01:13:51]

http://codereview.chromium.org/10175002/diff/1/ui/aura/event.cc
File ui/aura/event.cc (right):

http://codereview.chromium.org/10175002/diff/1/ui/aura/event.cc#newcode471
ui/aura/event.cc:471: delta_y_ *= scale.y();
On 2012/04/23 00:15:40, pkotwicz wrote:
> You are right that UpdateForRootTransform is never called on GestureEvent at
> present. But this can change and it would be nice for this to be correct.

I actually meant that the scale-factor on the root-window will already have been
taken into account by way of the touch-event location's transformation. So doing
this here again would mean the scale is applied twice, and that would be wrong.
So whether UpdateForRootTransform is applied or not, this change should not be
necessary.

[pkotwicz, 2012-04-23 20:50:40]

Remove GestureEvent handling as suggested by sadrul

[sadrul, 2012-04-23 22:48:20]

LGTM

[pkotwicz, 2012-04-23 22:59:34]

sky for OWNERS

[sky, 2012-04-23 23:41:37]

LGTM

[commit-bot: I haz the power, 2012-04-23 23:54:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10175002/6001

[commit-bot: I haz the power, 2012-04-24 02:16:03]

Change committed as 133604