Changed to Reset(bool clear_bound_vars)

Added parameter 'clear_bound_vars', so we could reset the statement without clearing bound variables, so and current row is reset to the beginning.

It is used to support the Andorid' sqlite cursor feature which could move the cursor around the result set.

BUG=
TEST=Added a new test.
TBR=agl,akalin,michaeln

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133985

[michaelbai, 2012-04-24 17:15:58]

ping

[brettw, 2012-04-24 23:12:30]

http://codereview.chromium.org/10171014/diff/1/sql/statement.h
File sql/statement.h (right):

http://codereview.chromium.org/10171014/diff/1/sql/statement.h#newcode96
sql/statement.h:96: void ResetWithoutClearingBoundVariables();
This name seems awkward and out of place. It looks like Reset is actually used
very rarely. How about just adding a param to that?
  void Reset(bool clear_bound_vars);

[michaelbai, 2012-04-25 17:10:52]

PTAL

http://codereview.chromium.org/10171014/diff/1/sql/statement.h
File sql/statement.h (right):

http://codereview.chromium.org/10171014/diff/1/sql/statement.h#newcode96
sql/statement.h:96: void ResetWithoutClearingBoundVariables();
On 2012/04/24 23:12:30, brettw wrote:
> This name seems awkward and out of place. It looks like Reset is actually used
> very rarely. How about just adding a param to that?
>   void Reset(bool clear_bound_vars);

Done.

[brettw, 2012-04-25 18:08:50]

lgtm

[commit-bot: I haz the power, 2012-04-25 18:11:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10171014/5001

[commit-bot: I haz the power, 2012-04-25 18:11:45]

Presubmit check for 10171014-5001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for files in these directories:
    chrome/browser/net
    sync
    webkit/appcache

Presubmit checks took 2.1s to calculate.

Was the presubmit check useful? Please send feedback & hate mail to
maruel@chromium.org!

[brettw, 2012-04-25 18:12:32]

I think you can TBR this change for the owners of those other dirs.

[commit-bot: I haz the power, 2012-04-25 18:22:54]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10171014/5001

[michaelbai, 2012-04-25 18:23:55]

On 2012/04/25 18:12:32, brettw wrote:
> I think you can TBR this change for the owners of those other dirs.

Thanks

[commit-bot: I haz the power, 2012-04-25 18:44:56]

Try job failure for 10171014-5001 (retry) on mac_rel for step "compile" (clobber
build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-25 20:10:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/michaelbai@chromium.org/10171014/7002

[commit-bot: I haz the power, 2012-04-25 21:36:43]

Change committed as 133985

[Scott Hess - ex-Googler, 2012-07-03 00:34:34]

http://codereview.chromium.org/10171014/diff/1/sql/statement.h
File sql/statement.h (right):

http://codereview.chromium.org/10171014/diff/1/sql/statement.h#newcode96
sql/statement.h:96: void ResetWithoutClearingBoundVariables();
On 2012/04/24 23:12:30, brettw wrote:
> This name seems awkward and out of place. It looks like Reset is actually used
> very rarely. How about just adding a param to that?
>   void Reset(bool clear_bound_vars);

In my imagination, ResetWithoutClearingBoundVariables() would have been used
just about once, and then only in a case where someone nominally knew what they
were doing (not true of most Reset() callers).  So right now I'm having a
two-minute hate for this brettw person.