Changed to Reset(bool clear_bound_vars)

sql/statement.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SQL_STATEMENT_H_
 #define SQL_STATEMENT_H_
 #pragma once
 
 #include <string>
 #include <vector>
@@ skipping 73 matching lines @@
   //   while (s.Step()) {
   //     ...
   //   }
   //   return s.Succeeded();
   bool Step();
 
   // Resets the statement to its initial condition. This includes clearing all
   // the bound variables and any current result row.
   void Reset();
 
+  // Resets the statement to its initial condition without clearing the bound
+  // variables.
+  void ResetWithoutClearingBoundVariables();

[brettw, 2012/04/24 23:12:30]

This name seems awkward and out of place. It looks like Reset is actually used
very rarely. How about just adding a param to that?
  void Reset(bool clear_bound_vars);

[michaelbai, 2012/04/25 17:10:52]

Done.

[Scott Hess - ex-Googler, 2012/07/03 00:34:34]

In my imagination, ResetWithoutClearingBoundVariables() would have been used
just about once, and then only in a case where someone nominally knew what they
were doing (not true of most Reset() callers).  So right now I'm having a
two-minute hate for this brettw person.

+
   // Returns true if the last executed thing in this statement succeeded. If
   // there was no last executed thing or the statement is invalid, this will
   // return false.
   bool Succeeded() const;
 
   // Binding -------------------------------------------------------------------
 
   // These all take a 0-based argument index and return true on success. You
   // may not always care about the return value (they'll DCHECK if they fail).
   // The main thing you may want to check is when binding large blobs or
@@ skipping 77 matching lines @@
 
   // See Succeeded() for what this holds.
   bool succeeded_;
 
   DISALLOW_COPY_AND_ASSIGN(Statement);
 };
 
 }  // namespace sql
 
 #endif  // SQL_STATEMENT_H_