Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 10170016: Add info about user agent overrides to WebContents (Closed)

Created:
8 years, 8 months ago by gone
Modified:
8 years, 7 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, marja+watch_chromium.org, jam, darin-cc_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Add info about user agent overrides to WebContents * NavigationEntries store booleans indicating whether they should be using an overridden user agent instead of the regular one. * WebContents stores a user agent override string that will (in a later CL) be sent to the renderer whenever the user agent needs to be overridden for a navigation entry. * Adds the requisite framework for saving and restoring this data from disk. Part of upstreaming b/5119921, tracked in b/6272286 BUG=112923 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=136683

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added SessionService saving #

Total comments: 8

Patch Set 3 : Fixing nits #

Patch Set 4 : Rebasing #

Patch Set 5 : Forgot to initialize bool in constructor; win_rel caught it #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -8 lines) Patch
M chrome/browser/sessions/base_session_service.h View 2 chunks +14 lines, -0 lines 0 comments Download
M chrome/browser/sessions/base_session_service.cc View 1 2 4 chunks +42 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_service.h View 1 2 3 2 chunks +6 lines, -1 line 0 comments Download
M chrome/browser/sessions/session_service.cc View 1 2 3 6 chunks +37 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_service_test_helper.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_service_test_helper.cc View 1 2 2 chunks +9 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_service_unittest.cc View 1 2 3 chunks +29 lines, -3 lines 0 comments Download
M chrome/browser/sessions/session_types.h View 1 2 3 3 chunks +11 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 1 2 6 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/sessions/tab_restore_service.cc View 4 chunks +24 lines, -1 line 0 comments Download
M content/browser/web_contents/navigation_entry_impl.h View 1 2 2 chunks +3 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl.cc View 1 2 3 4 3 chunks +10 lines, -0 lines 0 comments Download
M content/browser/web_contents/navigation_entry_impl_unittest.cc View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.h View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M content/browser/web_contents/web_contents_impl.cc View 1 2 3 1 chunk +8 lines, -0 lines 0 comments Download
M content/public/browser/navigation_entry.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/web_contents.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
gone
@Tony, darin: dpranke suggested you'd be the right people to ping about this CL. @sky: ...
8 years, 8 months ago (2012-04-23 22:19:19 UTC) #1
sky
Don't you need to update sessionservice too? https://chromiumcodereview.appspot.com/10170016/diff/1/chrome/browser/sessions/base_session_service.cc File chrome/browser/sessions/base_session_service.cc (right): https://chromiumcodereview.appspot.com/10170016/diff/1/chrome/browser/sessions/base_session_service.cc#newcode301 chrome/browser/sessions/base_session_service.cc:301: url_spec = ...
8 years, 8 months ago (2012-04-23 23:30:15 UTC) #2
gone
We actually don't use the SessionService on Android, so I missed adding that pathway. The ...
8 years, 8 months ago (2012-04-24 09:30:36 UTC) #3
sky
LGTM
8 years, 8 months ago (2012-04-24 15:50:16 UTC) #4
tony
LGTM, just some style/naming nits. https://chromiumcodereview.appspot.com/10170016/diff/13001/chrome/browser/sessions/base_session_service.cc File chrome/browser/sessions/base_session_service.cc (right): https://chromiumcodereview.appspot.com/10170016/diff/13001/chrome/browser/sessions/base_session_service.cc#newcode229 chrome/browser/sessions/base_session_service.cc:229: std::numeric_limits<SessionCommand::size_type>::max() - 1024; How ...
8 years, 7 months ago (2012-05-10 18:40:58 UTC) #5
gone
Fixed nits, added joi@ from content/public/OWNERS for changes to content/public/browser/* https://chromiumcodereview.appspot.com/10170016/diff/13001/chrome/browser/sessions/base_session_service.cc File chrome/browser/sessions/base_session_service.cc (right): https://chromiumcodereview.appspot.com/10170016/diff/13001/chrome/browser/sessions/base_session_service.cc#newcode229 ...
8 years, 7 months ago (2012-05-11 15:40:30 UTC) #6
Jói
LGTM
8 years, 7 months ago (2012-05-11 16:44:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dfalcantara@chromium.org/10170016/33003
8 years, 7 months ago (2012-05-11 20:12:55 UTC) #8
commit-bot: I haz the power
8 years, 7 months ago (2012-05-11 22:03:14 UTC) #9
Change committed as 136683

Powered by Google App Engine
This is Rietveld 408576698