Show download interrupt reason in a tooltip

Show download interrupt reason in a download item tooltip.

When the user hovers over a download item on the shelf that correspond to an interrupted download, the reason for the interruption is displayed in a tooltip.

(Original CL by ahendrickson http://codereview.chromium.org/9968090/ )

BUG=121698
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133907

[Nico, 2012-04-23 15:19:08]

Usual question: Did this go through UI review?

[asanka, 2012-04-23 18:28:31]

This is the same CL as http://codereview.chromium.org/9968090/ which I'm taking
over after ahendrickson's departure. Patchset 1 is identical to patchset 11 in
ahendrickson's CL. Patchset 2 addresses thakis's comments on that CL.

The UI leads were involved in the overall design of exposing download interrupt
reasons via the download shelf. However, some of the short status strings that
resulted from the discussion were too large for the download item button on the
shelf. The decision to truncate the reason string on the download shelf item and
then display the full string in a tooltip was arrived at after consulting the UI
leads.

A screenshot of the tooltip can be seen at :
http://www/~asanka/Download%20interrupt%20tooltip.PNG

Apologies for not mailing this out earlier with an explanation.

[Nico, 2012-04-23 23:25:03]

lgtm

http://codereview.chromium.org/10169025/diff/1005/chrome/browser/ui/gtk/downl...
File chrome/browser/ui/gtk/download/download_item_gtk.cc (right):

http://codereview.chromium.org/10169025/diff/1005/chrome/browser/ui/gtk/downl...
chrome/browser/ui/gtk/download/download_item_gtk.cc:490: }
This bit of code is very similar on all UIs. Maybe there should be a single
shared "GetTooltipText()" function on the model?

[asanka, 2012-04-24 22:34:01]

Thanks! I moved the tooltip generation logic into DownloadItemModel.

[Nico, 2012-04-24 22:36:19]

lgtm++

[sky, 2012-04-24 22:44:45]

LGTM

[commit-bot: I haz the power, 2012-04-25 12:28:22]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/asanka@chromium.org/10169025/16001

[commit-bot: I haz the power, 2012-04-25 14:16:24]

Change committed as 133907