Show download interrupt reason in a tooltip

chrome/browser/ui/views/download/download_item_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/download/download_item_view.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "base/bind.h"
@@ skipping 31 matching lines @@
 
 // TODO(paulg): These may need to be adjusted when download progress
 //              animation is added, and also possibly to take into account
 //              different screen resolutions.
 static const int kTextWidth = 140;            // Pixels
 static const int kDangerousTextWidth = 200;   // Pixels
 static const int kHorizontalTextPadding = 2;  // Pixels
 static const int kVerticalPadding = 3;        // Pixels
 static const int kVerticalTextSpacer = 2;     // Pixels
 static const int kVerticalTextPadding = 2;    // Pixels
+static const int kTooltipMaxWidth = 800;      // Pixels
 
 // We add some padding before the left image so that the progress animation icon
 // hides the corners of the left image.
 static const int kLeftPadding = 0;  // Pixels.
 
 // The space between the Save and Discard buttons when prompting for a dangerous
 // download.
 static const int kButtonPadding = 5;  // Pixels.
 
 // The space on the left and right side of the dangerous download label.
@@ skipping 115 matching lines @@
     rb.GetBitmapNamed(IDR_DOWNLOAD_BUTTON_RIGHT_TOP_NO_DD),
     rb.GetBitmapNamed(IDR_DOWNLOAD_BUTTON_RIGHT_MIDDLE_NO_DD),
     rb.GetBitmapNamed(IDR_DOWNLOAD_BUTTON_RIGHT_BOTTOM_NO_DD)
   };
   dangerous_mode_body_image_set_ = dangerous_mode_body_image_set;
 
   malicious_mode_body_image_set_ = normal_body_image_set;
 
   LoadIcon();
 
-  // Initial tooltip value.
-  tooltip_text_ = download_->GetFileNameToReportUser().LossyDisplayName();
-
   font_ = rb.GetFont(ui::ResourceBundle::BaseFont);
   box_height_ = std::max<int>(2 * kVerticalPadding + font_.GetHeight() +
                                   kVerticalTextPadding + font_.GetHeight(),
                               2 * kVerticalPadding +
                                   normal_body_image_set_.top_left->height() +
                                   normal_body_image_set_.bottom_left->height());
 
   if (download_util::kSmallProgressIconSize > box_height_)
     box_y_ = (download_util::kSmallProgressIconSize - box_height_) / 2;
   else
     box_y_ = kVerticalPadding;
 
   body_hover_animation_.reset(new ui::SlideAnimation(this));
   drop_hover_animation_.reset(new ui::SlideAnimation(this));
 
   UpdateDropDownButtonPosition();
 
+  tooltip_text_ = model_->GetTooltipText(font_, kTooltipMaxWidth);
+
   if (model_->IsDangerous())
     ShowWarningDialog();
 
   UpdateAccessibleName();
   set_accessibility_focusable(true);
 
   // Set up our animation.
   StartDownloadProgress();
 }
 
@@ skipping 30 matching lines @@
     parent()->SchedulePaint();
 }
 
 // DownloadObserver interface.
 
 // Update the progress graphic on the icon and our text status label
 // to reflect our current bytes downloaded, time remaining.
 void DownloadItemView::OnDownloadUpdated(DownloadItem* download) {
   DCHECK(download == download_);
 
-  string16 old_tip = tooltip_text_;
-  content::DownloadInterruptReason reason = download_->GetLastReason();
-
-  if ((download_->GetState() == DownloadItem::INTERRUPTED) &&
-      (reason != content::DOWNLOAD_INTERRUPT_REASON_USER_CANCELED)) {
-    // Use two lines: The file name, and the message.
-    tooltip_text_ = download_->GetFileNameToReportUser().LossyDisplayName();
-    tooltip_text_ += ASCIIToUTF16("\n");
-    // The message is localized.
-    tooltip_text_ += DownloadItemModel::InterruptReasonMessage(reason);
-  } else {
-    tooltip_text_ = download_->GetFileNameToReportUser().LossyDisplayName();
-  }
-
   if (IsShowingWarningDialog() && !model_->IsDangerous()) {
     // We have been approved.
     ClearWarningDialog();
   } else if (!IsShowingWarningDialog() && model_->IsDangerous()) {
     ShowWarningDialog();
     // Force the shelf to layout again as our size has changed.
     parent_->Layout();
     SchedulePaint();
   } else {
     string16 status_text = model_->GetStatusText();
@@ skipping 31 matching lines @@
         break;
       case DownloadItem::REMOVING:
         parent_->RemoveDownloadView(this);  // This will delete us!
         return;
       default:
         NOTREACHED();
     }
     status_text_ = status_text;
   }
 
-  if (old_tip != tooltip_text_)
+  string16 new_tip = model_->GetTooltipText(font_, kTooltipMaxWidth);
+  if (new_tip != tooltip_text_) {
+    tooltip_text_ = new_tip;
     TooltipTextChanged();
+  }
 
   UpdateAccessibleName();
 
   // We use the parent's (DownloadShelfView's) SchedulePaint, since there
   // are spaces between each DownloadItemView that the parent is responsible
   // for painting.
   parent()->SchedulePaint();
 }
 
 void DownloadItemView::OnDownloadOpened(DownloadItem* download) {
@@ skipping 854 matching lines @@
     // Drop down button is glued to the left of the download shelf.
     drop_down_x_left_ = 0;
     drop_down_x_right_ = normal_drop_down_image_set_.top->width();
   } else {
     // Drop down button is glued to the right of the download shelf.
     drop_down_x_left_ =
       size.width() - normal_drop_down_image_set_.top->width();
     drop_down_x_right_ = size.width();
   }
 }