Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(395)

Issue 10166012: [Coverity] pass-by-ref instead of pass-by-val (Closed)

Created:
8 years, 8 months ago by groby-ooo-7-16
Modified:
8 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Coverity] pass-by-ref instead of pass-by-val CID=103838 R=estade@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133492

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -2 lines) Patch
M chrome/browser/ui/gtk/find_bar_gtk.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/find_bar_gtk.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
groby-ooo-7-16
8 years, 8 months ago (2012-04-20 20:29:58 UTC) #1
Evan Stade
lgtm
8 years, 8 months ago (2012-04-20 20:38:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/groby@chromium.org/10166012/1
8 years, 8 months ago (2012-04-23 16:49:41 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 19:24:44 UTC) #4
Change committed as 133492

Powered by Google App Engine
This is Rietveld 408576698