chrome/browser/ui/gtk/find_bar_gtk.cc - Issue 10166012: [Coverity] pass-by-ref instead of pass-by-val

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/find_bar_gtk.cc

Issue 10166012: [Coverity] pass-by-ref instead of pass-by-val (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/gtk/find_bar_gtk.cc

diff --git a/chrome/browser/ui/gtk/find_bar_gtk.cc b/chrome/browser/ui/gtk/find_bar_gtk.cc

index 9f5dc36268f7e5e80dcf15d1c2746beeead4fdd2..799d5ff8f4e153803cf045998a07fd6d387122fd 100644

--- a/chrome/browser/ui/gtk/find_bar_gtk.cc

+++ b/chrome/browser/ui/gtk/find_bar_gtk.cc

@@ -418,7 +418,8 @@ void FindBarGtk::AudibleAlert() {

// gtk_widget_error_bell(widget());

}

-gfx::Rect FindBarGtk::GetDialogPosition(gfx::Rect avoid_overlapping_rect) {

+gfx::Rect FindBarGtk::GetDialogPosition(

+ const gfx::Rect& avoid_overlapping_rect) {

bool ltr = !base::i18n::IsRTL();

// 15 is the size of the scrollbar, copied from ScrollbarThemeChromium.

// The height is not used.

« no previous file with comments | « chrome/browser/ui/gtk/find_bar_gtk.h ('k') | no next file » | no next file with comments »