Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 10166002: History: Fix string indicating the wrong shortcut for incognito mode on Mac. (Closed)

Created:
8 years, 8 months ago by Patrick Dubroy
Modified:
8 years, 8 months ago
Reviewers:
James Hawkins
CC:
chromium-reviews
Visibility:
Public.

Description

History: Fix string indicating the wrong shortcut for incognito mode on Mac. BUG=124371 TEST=Open chrome://history, select an entry and click "Remove selected items". The dialog should show the proper shortcut (<shift-symbol><command-symbol>N). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133416

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M chrome/browser/ui/webui/history_ui.cc View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Patrick Dubroy
James, please take a look.
8 years, 8 months ago (2012-04-20 11:09:18 UTC) #1
James Hawkins
lgtm
8 years, 8 months ago (2012-04-20 16:39:15 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dubroy@chromium.org/10166002/1
8 years, 8 months ago (2012-04-23 07:19:14 UTC) #3
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 09:14:02 UTC) #4
Change committed as 133416

Powered by Google App Engine
This is Rietveld 408576698