Pass TransportConfig to TransportFactory instead of Transport.

remoting/protocol/transport.h

Index: remoting/protocol/transport.h
diff --git a/remoting/protocol/transport.h b/remoting/protocol/transport.h
index 47de7de0199b3389cd8137f559e66031753fd94a..01b0491917bbb8d208f68bd1d7107b58d10734dd 100644
--- a/remoting/protocol/transport.h
+++ b/remoting/protocol/transport.h
@@ -91,7 +91,6 @@ class Transport : public base::NonThreadSafe {
   // Intialize the transport with the specified parameters.
   // |authenticator| is used to secure and authenticate the connection.
   virtual void Initialize(const std::string& name,
-                          const TransportConfig& config,
                           Transport::EventHandler* event_handler,
                           scoped_ptr<ChannelAuthenticator> authenticator) = 0;
 
@@ -141,6 +140,8 @@ class TransportFactory {
   TransportFactory() { }
   virtual ~TransportFactory() { }
 
+  virtual void SetConfig(const TransportConfig& config) = 0;

[Wez, 2012/04/27 23:49:15]

Add some comments to explain this interface, please. :)

[Wez, 2012/04/27 23:49:15]

SetConfig -> SetTransportConfig

[Wez, 2012/04/27 23:49:15]

Why do you want the TransportConfig to apply per-TransportFactory rather than
per-Transport?  What if we want to e.g. have different sessions have different
transport properties?

[Sergey Ulanov, 2012/04/28 00:18:19]

Done.

[Sergey Ulanov, 2012/04/28 00:18:19]

Done.

[Sergey Ulanov, 2012/04/28 00:18:19]

That's in order to be able to share PortAllocator between Transports. The
transport config specified stun/relay configuration, and I don't think we would
want to use different stun/relay servers for different transport instances.

[Wez, 2012/04/30 19:33:13]

We will want to be able to enable/disable NAT traversal & "incoming" mode on a
per-session basis, which will require per-Transport configuration, though?

[Sergey Ulanov, 2012/04/30 20:14:29]

As we discussed we don't really need to be able to enable/disable NAT traversal
per-session.

+
   virtual scoped_ptr<StreamTransport> CreateStreamTransport() = 0;
   virtual scoped_ptr<DatagramTransport> CreateDatagramTransport() = 0;