Pass TransportConfig to TransportFactory instead of Transport.

remoting/protocol/transport.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines the interface for peer-to-peer transport. There
 // are two types of transport: StreamTransport and DatagramTransport.
 // They must both be created using TransportFactory instances and they
 // provide the same interface, except that one should be used for
 // reliable stream connection and the other one for unreliable
 // datagram connection. The Transport interface itself doesn't provide
@@ skipping 73 matching lines @@
     // Called when the transport is about to be deleted.
     virtual void OnTransportDeleted(Transport* transport) = 0;
   };
 
   Transport() {}
   virtual ~Transport() {}
 
   // Intialize the transport with the specified parameters.
   // |authenticator| is used to secure and authenticate the connection.
   virtual void Initialize(const std::string& name,
-                          const TransportConfig& config,
                           Transport::EventHandler* event_handler,
                           scoped_ptr<ChannelAuthenticator> authenticator) = 0;
 
   // Adds |candidate| received from the peer.
   virtual void AddRemoteCandidate(const cricket::Candidate& candidate) = 0;
 
   // Name of the channel. It is used to identify the channel and
   // disambiguate candidates it generates from candidates generated by
   // parallel connections.
   virtual const std::string& name() const = 0;
@@ skipping 29 matching lines @@
 
  private:
   DISALLOW_COPY_AND_ASSIGN(DatagramTransport);
 };
 
 class TransportFactory {
  public:
   TransportFactory() { }
   virtual ~TransportFactory() { }
 
+  virtual void SetConfig(const TransportConfig& config) = 0;

[Wez, 2012/04/27 23:49:15]

Add some comments to explain this interface, please. :)

[Wez, 2012/04/27 23:49:15]

SetConfig -> SetTransportConfig

[Wez, 2012/04/27 23:49:15]

Why do you want the TransportConfig to apply per-TransportFactory rather than
per-Transport?  What if we want to e.g. have different sessions have different
transport properties?

[Sergey Ulanov, 2012/04/28 00:18:19]

Done.

[Sergey Ulanov, 2012/04/28 00:18:19]

Done.

[Sergey Ulanov, 2012/04/28 00:18:19]

That's in order to be able to share PortAllocator between Transports. The
transport config specified stun/relay configuration, and I don't think we would
want to use different stun/relay servers for different transport instances.

[Wez, 2012/04/30 19:33:13]

We will want to be able to enable/disable NAT traversal & "incoming" mode on a
per-session basis, which will require per-Transport configuration, though?

[Sergey Ulanov, 2012/04/30 20:14:29]

As we discussed we don't really need to be able to enable/disable NAT traversal
per-session.

+
   virtual scoped_ptr<StreamTransport> CreateStreamTransport() = 0;
   virtual scoped_ptr<DatagramTransport> CreateDatagramTransport() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(TransportFactory);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_TRANSPORT_H_