DomStorage async IPC message definitions and browser-side handlers. These messages aren't called ye…

DomStorage async IPC message definitions and browser-side handlers. These messages aren't called yet by the renderer-side.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133576

[michaeln, 2012-04-20 15:24:51]

http://codereview.chromium.org/10160003/diff/12005/content/browser/dom_storag...
File content/browser/dom_storage/dom_storage_message_filter.cc (right):

http://codereview.chromium.org/10160003/diff/12005/content/browser/dom_storag...
content/browser/dom_storage/dom_storage_message_filter.cc:125: }
i think we'll also need to send a separate message to tell the client-side to
start updating the cached area upon receipt of mutation events. any mutation
events processed by the client prior to receipt of that  message should not be
applied.

sync responses get pulled into the main thread on the client-side
'out-of-order'... it's possible for there to be older in-flight mutation events
queued up for dispatch after the cache is in place. it would be incorrect to
apply those updates.

when i get to the client-side part of this i'll look into those details

[ericu, 2012-04-20 23:36:00]

http://codereview.chromium.org/10160003/diff/12005/webkit/dom_storage/dom_sto...
File webkit/dom_storage/dom_storage_area.cc (right):

http://codereview.chromium.org/10160003/diff/12005/webkit/dom_storage/dom_sto...
webkit/dom_storage/dom_storage_area.cc:79: map_->SwapValues(&current_values);
As discussed, SwapValues leads to too much accounting overhead.  Add a copy
method to DomStorageMap to avoid that and make this code much easier to read.

[michaeln, 2012-04-20 23:42:19]

http://codereview.chromium.org/10160003/diff/12005/webkit/dom_storage/dom_sto...
File webkit/dom_storage/dom_storage_area.cc (right):

http://codereview.chromium.org/10160003/diff/12005/webkit/dom_storage/dom_sto...
webkit/dom_storage/dom_storage_area.cc:79: map_->SwapValues(&current_values);
On 2012/04/20 23:36:00, ericu wrote:
> As discussed, SwapValues leads to too much accounting overhead.  Add a copy
> method to DomStorageMap to avoid that and make this code much easier to read.

Yup, done.

[ericu, 2012-04-20 23:47:43]

LGTM.

Muuuuuuuch nicer.