DomStorage async IPC message definitions and browser-side handlers. These messages aren't called ye…

webkit/dom_storage/dom_storage_area.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "webkit/dom_storage/dom_storage_area.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 53 matching lines @@
   if (namespace_id == kLocalStorageNamespaceId && !directory.empty()) {
     FilePath path = directory.Append(DatabaseFileNameFromOrigin(origin_));
     backing_.reset(new DomStorageDatabase(path));
     is_initial_import_done_ = false;
   }
 }
 
 DomStorageArea::~DomStorageArea() {
 }
 
+void DomStorageArea::ExtractValues(ValuesMap* map) {
+  if (is_shutdown_)
+    return;
+  InitialImportIfNeeded();
+  ValuesMap current_values;
+  map_->SwapValues(&current_values);

[ericu, 2012/04/20 23:36:00]

As discussed, SwapValues leads to too much accounting overhead.  Add a copy
method to DomStorageMap to avoid that and make this code much easier to read.

[michaeln, 2012/04/20 23:42:19]

Yup, done.

+  *map = current_values;
+  map_->SwapValues(&current_values);
+}
+
 unsigned DomStorageArea::Length() {
   if (is_shutdown_)
     return 0;
   InitialImportIfNeeded();
   return map_->Length();
 }
 
 NullableString16 DomStorageArea::Key(unsigned index) {
   if (is_shutdown_)
     return NullableString16(true);
@@ skipping 213 matching lines @@
         commit_batch_->clear_all_first,
         commit_batch_->changed_values);
     DCHECK(success);
   }
   commit_batch_.reset();
   in_flight_commit_batch_.reset();
   backing_.reset();
 }
 
 }  // namespace dom_storage