Issue 10155022: Add back accelerator labels for C-n and C-S-n to the wrench menu.

Issue 10155022: Add back accelerator labels for C-n and C-S-n to the wrench menu. (Closed)

Created:
8 years, 8 months ago by Yusuke Sato

Modified:
8 years, 8 months ago

Reviewers:
mazda, Ben Goodger (Google)

CC:
chromium-reviews, mazda+watch_chromium.org, sadrul, derat+watch_chromium.org, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add back accelerator labels for C-n and C-S-n to the wrench menu. BUG=123856 BUG=120196 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133856

Patch Set 3 : address comment #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -0 lines)			Patch
	M	ash/accelerators/accelerator_table.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download
	M	chrome/browser/ui/views/toolbar_view.cc	View	1 2	1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

mazda

LGTM with a comment http://codereview.chromium.org/10155022/diff/3001/chrome/browser/ui/views/toolbar_view.cc File chrome/browser/ui/views/toolbar_view.cc (right): http://codereview.chromium.org/10155022/diff/3001/chrome/browser/ui/views/toolbar_view.cc#newcode493 chrome/browser/ui/views/toolbar_view.cc:493: #if defined(USE_ASH) Could you add ...

8 years, 8 months ago (2012-04-24 19:34:06 UTC) #2

Ben Goodger (Google)

LGTM2 On Tue, Apr 24, 2012 at 12:34 PM, <mazda@chromium.org> wrote: > LGTM with a ...

8 years, 8 months ago (2012-04-24 21:18:27 UTC) #3

Yusuke Sato

http://codereview.chromium.org/10155022/diff/3001/chrome/browser/ui/views/toolbar_view.cc File chrome/browser/ui/views/toolbar_view.cc (right): http://codereview.chromium.org/10155022/diff/3001/chrome/browser/ui/views/toolbar_view.cc#newcode493 chrome/browser/ui/views/toolbar_view.cc:493: #if defined(USE_ASH) On 2012/04/24 19:34:06, mazda wrote: > Could ...

8 years, 8 months ago (2012-04-25 01:27:30 UTC) #4

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yusukes@chromium.org/10155022/10001

8 years, 8 months ago (2012-04-25 01:27:54 UTC) #5

Change committed as 133856

Expand Messages | Collapse Messages