Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: chrome/browser/ui/views/toolbar_view.cc

Issue 10155022: Add back accelerator labels for C-n and C-S-n to the wrench menu. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: address comment Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ash/accelerators/accelerator_table.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar_view.cc
diff --git a/chrome/browser/ui/views/toolbar_view.cc b/chrome/browser/ui/views/toolbar_view.cc
index 46a2edaaca6de6e879306dd4f6360997e91d25ef..819e9645aa076459c64fd80bc129981a4bde6497 100644
--- a/chrome/browser/ui/views/toolbar_view.cc
+++ b/chrome/browser/ui/views/toolbar_view.cc
@@ -490,6 +490,17 @@ bool ToolbarView::GetAcceleratorForCommandId(int command_id,
case IDC_PASTE:
*accelerator = ui::Accelerator(ui::VKEY_V, false, true, false);
return true;
+#if defined(USE_ASH)
+ // When USE_ASH is defined, IDC_NEW_WINDOW and IDC_NEW_INCOGNITO_WINDOW are
+ // handled outside Chrome, in ash/accelerators/accelerator_table.cc.
+ // crbug.com/120196
+ case IDC_NEW_WINDOW:
+ *accelerator = ui::Accelerator(ui::VKEY_N, false, true, false);
+ return true;
+ case IDC_NEW_INCOGNITO_WINDOW:
+ *accelerator = ui::Accelerator(ui::VKEY_N, true, true, false);
+ return true;
+#endif
}
// Else, we retrieve the accelerator information from the frame.
return GetWidget()->GetAccelerator(command_id, accelerator);
« no previous file with comments | « ash/accelerators/accelerator_table.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698