Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 1014007: Add test cases for fast smi loops. (Closed)

Created:
10 years, 9 months ago by fschneider
Modified:
9 years, 6 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Add test cases for fast smi loops. Committed: http://code.google.com/p/v8/source/detail?r=4174

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -3 lines) Patch
M src/ia32/codegen-ia32.cc View 2 chunks +4 lines, -3 lines 4 comments Download
M test/mjsunit/compiler/loopcount.js View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
fschneider
10 years, 9 months ago (2010-03-17 18:05:09 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/1014007/diff/1/3 File src/ia32/codegen-ia32.cc (right): http://codereview.chromium.org/1014007/diff/1/3#newcode3731 src/ia32/codegen-ia32.cc:3731: // and (b) the loop induction variable is ...
10 years, 9 months ago (2010-03-18 08:52:50 UTC) #2
fschneider
10 years, 9 months ago (2010-03-18 09:08:20 UTC) #3
http://codereview.chromium.org/1014007/diff/1/3
File src/ia32/codegen-ia32.cc (right):

http://codereview.chromium.org/1014007/diff/1/3#newcode3731
src/ia32/codegen-ia32.cc:3731: // and (b) the loop induction variable is not
assignend inside the
On 2010/03/18 08:52:50, William Hesse wrote:
> The added sentence is not capitalized, and has no verb.
> How about, instead,
> 
> // We know that the loop index is a smi if it is not modified in the loop body
> and it is checked against a constant limit in the loop condition.  In this
case,
> we reset the static type information of the loop index to smi before compiling
> the body, the update expression, and the bottom check of the loop condition.

Done.

http://codereview.chromium.org/1014007/diff/1/3#newcode3768
src/ia32/codegen-ia32.cc:3768: // expression if we are in a fast smi loop.
On 2010/03/18 08:52:50, William Hesse wrote:
> loop condition?

Done.

Powered by Google App Engine
This is Rietveld 408576698