Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Unified Diff: src/ia32/codegen-ia32.cc

Issue 1014007: Add test cases for fast smi loops. (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/mjsunit/compiler/loopcount.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ia32/codegen-ia32.cc
===================================================================
--- src/ia32/codegen-ia32.cc (revision 4172)
+++ src/ia32/codegen-ia32.cc (working copy)
@@ -3730,7 +3730,8 @@
// If we have (a) a loop with a compile-time constant trip count
// and (b) the loop induction variable is not assignend inside the
William Hesse 2010/03/18 08:52:50 The added sentence is not capitalized, and has no
fschneider 2010/03/18 09:08:20 Done.
// loop we update the number type of the induction variable to be smi.
-
+ // before generating the body, the update expression and the test at
+ // the bottom.
if (node->is_fast_smi_loop()) {
// Set number type of the loop variable to smi.
Slot* slot = node->loop_variable()->slot();
@@ -3763,8 +3764,8 @@
}
}
- // The update expression resets the type of the loop variable. So we
- // set it to smi before compiling the test expression.
+ // Set the type of the loop variable to smi before compiling the test
+ // expression if we are in a fast smi loop.
William Hesse 2010/03/18 08:52:50 loop condition?
fschneider 2010/03/18 09:08:20 Done.
if (node->is_fast_smi_loop()) {
// Set number type of the loop variable to smi.
Slot* slot = node->loop_variable()->slot();
« no previous file with comments | « no previous file | test/mjsunit/compiler/loopcount.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698