Issue 10139028: Reland 9985005 with fix for clang

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10139028: Reland 9985005 with fix for clang (Closed)

Created:
8 years, 8 months ago by Zachary Kuznia

Modified:
8 years, 8 months ago

Reviewers:
sky

CC:
chromium-reviews, sadrul, ben+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Reland http://codereview.chromium.org/9985005 with fix for clang Add accessibility info to app list items and allow them to be focused. TBR=sky@chromium.org BUG=120496 TEST=See Bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133424

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -0 lines)			Patch
	M	ash/app_list/app_list_item_view.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	ash/app_list/app_list_item_view.cc	View		4 chunks	+8 lines, -0 lines	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/10139028/1

8 years, 8 months ago (2012-04-23 08:32:54 UTC) #1

Change committed as 133424