Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9985005: Add accessibility info to app list items and allow them to be focused. (Closed)

Created:
8 years, 8 months ago by Zachary Kuznia
Modified:
8 years, 8 months ago
Reviewers:
Jun Mukai, sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Add accessibility info to app list items and allow them to be focused. R=mukai@chromium.org BUG=120496 TEST=See Bug Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133408

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review fix #

Total comments: 2

Patch Set 3 : Remove extra include #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -0 lines) Patch
M ash/app_list/app_list_item_view.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M ash/app_list/app_list_item_view.cc View 1 2 4 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Zachary Kuznia
8 years, 8 months ago (2012-04-19 05:33:40 UTC) #1
Jun Mukai
lgtm
8 years, 8 months ago (2012-04-19 05:44:25 UTC) #2
Zachary Kuznia
Hello sky, Could you do an OWNERS review on this? Thanks, -Zach
8 years, 8 months ago (2012-04-19 08:16:54 UTC) #3
sky
https://chromiumcodereview.appspot.com/9985005/diff/1/ash/app_list/app_list_item_view.cc File ash/app_list/app_list_item_view.cc (right): https://chromiumcodereview.appspot.com/9985005/diff/1/ash/app_list/app_list_item_view.cc#newcode370 ash/app_list/app_list_item_view.cc:370: state->name = accessible_name_; Since title_ has the text you ...
8 years, 8 months ago (2012-04-19 15:47:14 UTC) #4
Zachary Kuznia
https://chromiumcodereview.appspot.com/9985005/diff/1/ash/app_list/app_list_item_view.cc File ash/app_list/app_list_item_view.cc (right): https://chromiumcodereview.appspot.com/9985005/diff/1/ash/app_list/app_list_item_view.cc#newcode370 ash/app_list/app_list_item_view.cc:370: state->name = accessible_name_; On 2012/04/19 15:47:14, sky wrote: > ...
8 years, 8 months ago (2012-04-20 07:18:50 UTC) #5
sky
LGTM https://chromiumcodereview.appspot.com/9985005/diff/6001/ash/app_list/app_list_item_view.cc File ash/app_list/app_list_item_view.cc (right): https://chromiumcodereview.appspot.com/9985005/diff/6001/ash/app_list/app_list_item_view.cc#newcode27 ash/app_list/app_list_item_view.cc:27: #include "ui/views/widget/widget.h" Do you really need this include?
8 years, 8 months ago (2012-04-20 15:33:25 UTC) #6
Zachary Kuznia
https://chromiumcodereview.appspot.com/9985005/diff/6001/ash/app_list/app_list_item_view.cc File ash/app_list/app_list_item_view.cc (right): https://chromiumcodereview.appspot.com/9985005/diff/6001/ash/app_list/app_list_item_view.cc#newcode27 ash/app_list/app_list_item_view.cc:27: #include "ui/views/widget/widget.h" On 2012/04/20 15:33:26, sky wrote: > Do ...
8 years, 8 months ago (2012-04-23 05:59:23 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zork@chromium.org/9985005/7004
8 years, 8 months ago (2012-04-23 05:59:40 UTC) #8
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 07:15:37 UTC) #9 
Change committed as 133408

Powered by Google App Engine
This is Rietveld 408576698