Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 10139023: Handle move of WebKit's WebReferrerPolicy.h (Closed)

Created:
8 years, 8 months ago by gavinp
Modified:
8 years, 8 months ago
Reviewers:
jamesr, jabdelmalek, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Handle move of WebKit's WebReferrerPolicy.h After WebKit gardens past r115200, these renames prepare us to land webkit bug https://bugs.webkit.org/show_bug.cgi?id=84552 . This is part of the Prerendering API, from http://codereview.chromium.org/9875026/ BUG=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134143

Patch Set 1 #

Patch Set 2 : fix (preexisting) style problem in context_menu_params.h #

Patch Set 3 : updated wrt landed commonparamtraits patch... #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -8 lines) Patch
M chrome/browser/external_tab/external_tab_container_win.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/browser/resource_request_info.h View 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/common_param_traits.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/public/common/context_menu_params.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/referrer.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/resource_loader_bridge.h View 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/weburlrequest_extradata_impl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (0 generated)
gavinp
For the Prerendering API, the WebReferrerPolicy needs to move around a bit in the WebKit ...
8 years, 8 months ago (2012-04-25 16:05:37 UTC) #1
gavinp
jam, wdyt?
8 years, 8 months ago (2012-04-25 16:06:52 UTC) #2
gavinp
(which is the correct jam?)
8 years, 8 months ago (2012-04-25 16:09:46 UTC) #3
gavinp
As of r133920, we've gardened past WebKit r115200, so this patch can land if the ...
8 years, 8 months ago (2012-04-25 17:33:03 UTC) #4
jam
lgtm
8 years, 8 months ago (2012-04-25 21:20:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10139023/10001
8 years, 8 months ago (2012-04-26 14:33:04 UTC) #6
commit-bot: I haz the power
Presubmit check for 10139023-10001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-26 14:33:09 UTC) #7
gavinp
Jamesr, I forgot to get a webkit/ LGTM. WDYT?
8 years, 8 months ago (2012-04-26 14:47:51 UTC) #8
jamesr
lgtm
8 years, 8 months ago (2012-04-26 18:14:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gavinp@chromium.org/10139023/10001
8 years, 8 months ago (2012-04-26 18:31:25 UTC) #10
commit-bot: I haz the power
8 years, 8 months ago (2012-04-26 20:12:16 UTC) #11
Change committed as 134143

Powered by Google App Engine
This is Rietveld 408576698