Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Issue 10134029: NaCl: Don't pass the NaCl process's Windows handle to the renderer process (Closed)

Created:
8 years, 8 months ago by Mark Seaborn
Modified:
8 years, 8 months ago
CC:
chromium-reviews, native-client-reviews_googlegroups.com, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

NaCl: Don't pass the NaCl process's Windows handle to the renderer process The process handle is not used since we switched NaCl to using Chromium's BrokerDuplicateHandle() function. I have changed NaCl's SelLdrLauncher to not use the process ID or process handle in this context, so returning dummy values of 0 and -1 will be OK: they will not get passed to kill(), waitpid() or TerminateProcess(). BUG=http://code.google.com/p/nativeclient/issues/detail?id=2719 TEST=nacl_integration etc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133523

Patch Set 1 #

Patch Set 2 : Use C-style cast #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -35 lines) Patch
M chrome/browser/nacl_host/nacl_process_host.cc View 1 chunk +2 lines, -24 lines 0 comments Download
M chrome/common/render_messages.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/renderer/chrome_ppapi_interfaces.cc View 1 2 chunks +6 lines, -7 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
8 years, 8 months ago (2012-04-23 15:31:00 UTC) #1
jschuh
On 2012/04/23 15:31:00, Mark Seaborn wrote: lgtm
8 years, 8 months ago (2012-04-23 16:45:12 UTC) #2
sehr (please use chromium)
lgtm
8 years, 8 months ago (2012-04-23 18:32:05 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/10134029/8001
8 years, 8 months ago (2012-04-23 20:02:31 UTC) #4
Mark Seaborn
http://codereview.chromium.org/10134029/diff/8001/chrome/renderer/chrome_ppapi_interfaces.cc File chrome/renderer/chrome_ppapi_interfaces.cc (right): http://codereview.chromium.org/10134029/diff/8001/chrome/renderer/chrome_ppapi_interfaces.cc#newcode62 chrome/renderer/chrome_ppapi_interfaces.cc:62: (base::ProcessHandle) -1; As I discussed with David, I had ...
8 years, 8 months ago (2012-04-23 20:04:15 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 21:34:16 UTC) #6
Change committed as 133523

Powered by Google App Engine
This is Rietveld 408576698