NaCl: Don't pass the NaCl process's Windows handle to the renderer process

chrome/renderer/chrome_ppapi_interfaces.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/renderer/chrome_ppapi_interfaces.h"
 
 #include "base/command_line.h"
 #include "base/lazy_instance.h"
 #include "base/logging.h"
 #include "base/rand_util_c.h"
@@ skipping 24 matching lines @@
 namespace {
 base::LazyInstance<scoped_refptr<IPC::SyncMessageFilter> >
     g_background_thread_sender = LAZY_INSTANCE_INITIALIZER;
 }  // namespace
 
 // Launch NaCl's sel_ldr process.
 bool LaunchSelLdr(const char* alleged_url, int socket_count,
                   void* imc_handles, void* nacl_process_handle,
                   int* nacl_process_id) {
   std::vector<nacl::FileDescriptor> sockets;
-  base::ProcessHandle nacl_process;
   IPC::Message::Sender* sender = RenderThread::Get();
   if (sender == NULL) {
     sender = g_background_thread_sender.Pointer()->get();
   }
   if (!sender->Send(
       new ChromeViewHostMsg_LaunchNaCl(
-          GURL(alleged_url),
-          socket_count,
-          &sockets,
-          &nacl_process,
-          reinterpret_cast<base::ProcessId*>(nacl_process_id)))) {
+          GURL(alleged_url), socket_count, &sockets))) {
     return false;
   }
   CHECK(static_cast<int>(sockets.size()) == socket_count);
   for (int i = 0; i < socket_count; i++) {
     static_cast<nacl::Handle*>(imc_handles)[i] =
         nacl::ToNativeHandle(sockets[i]);
   }
-  *static_cast<nacl::Handle*>(nacl_process_handle) = nacl_process;
+  // TODO(mseaborn): Remove the arguments nacl_process_handle and
+  // nacl_process_id from the interface.
+  *reinterpret_cast<base::ProcessHandle*>(nacl_process_handle) =
+      (base::ProcessHandle) -1;

[Mark Seaborn, 2012/04/23 20:04:16]

As I discussed with David, I had to change this to a C-style cast to make it
compile on Linux and Windows, since neither static_cast and reinterpret_cast
work for converting an int to both an int (Unix) and a void* (Windows).

+  *nacl_process_id = 0;
   return true;
 }
 
 int UrandomFD(void) {
 #if defined(OS_POSIX)
   return GetUrandomFD();
 #else
   return 0;
 #endif
 }
@@ skipping 43 matching lines @@
 #if !defined(DISABLE_NACL)
   if (interface_name == PPB_NACL_PRIVATE_INTERFACE)
     return chrome::PPB_NaCl_Impl::GetInterface();
 #endif  // DISABLE_NACL
   if (interface_name == PPB_PDF_INTERFACE)
     return chrome::PPB_PDF_Impl::GetInterface();
   return NULL;
 }
 
 }  // namespace chrome