Issue 10122011: Do not use overloaded toDartValue for primitive types.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10122011: Do not use overloaded toDartValue for primitive types. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
Anton Muhin, antonm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Do not use overloaded toDartValue for primitive types. R=antonm@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6797

Patch Set 2 : Generate arguments array in handleEvent callback. #

Patch Set 3 : Use capwords. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -24 lines)			Patch
	M	lib/dom/scripts/generator.py	View	1 2	6 chunks	+16 lines, -17 lines	0 comments	Download
	M	lib/dom/scripts/systemnative.py	View	1	2 chunks	+15 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

LGTM https://chromiumcodereview.appspot.com/10122011/diff/1/lib/dom/scripts/generator.py File lib/dom/scripts/generator.py (right): https://chromiumcodereview.appspot.com/10122011/diff/1/lib/dom/scripts/generator.py#newcode546 lib/dom/scripts/generator.py:546: words = self.native_type().split(' ') maybe use string.capwords: http://docs.python.org/library/string.html#string.capwords ...

8 years, 8 months ago (2012-04-19 19:45:02 UTC) #2

podivilov

8 years, 8 months ago (2012-04-20 13:11:07 UTC) #3

http://codereview.chromium.org/10122011/diff/1/lib/dom/scripts/generator.py
File lib/dom/scripts/generator.py (right):

http://codereview.chromium.org/10122011/diff/1/lib/dom/scripts/generator.py#n...
lib/dom/scripts/generator.py:546: words = self.native_type().split(' ')
On 2012/04/19 19:45:02, antonmuhin wrote:
> maybe use string.capwords:
> http://docs.python.org/library/string.html#string.capwords ?

Don't think it could help here.