chrome/browser/ui/gtk/extensions/shell_window_gtk.h - Issue 10119003: Pull shell window stuff out of ExtensionHost and put in ShellWindow

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/gtk/extensions/shell_window_gtk.h

Issue 10119003: Pull shell window stuff out of ExtensionHost and put in ShellWindow (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Comments Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/extensions/shell_window.h ('K') | « chrome/browser/ui/extensions/shell_window.cc ('k') | chrome/browser/ui/gtk/extensions/shell_window_gtk.cc » ('j') | chrome/browser/ui/views/extensions/shell_window_views.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/gtk/extensions/shell_window_gtk.h

diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h

index 37455486b73c54d35a33ff8b1275193ed95291ac..aaf4c714bc5e35194f60f43cd1c1ab33b05d2503 100644

--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.h

+++ b/chrome/browser/ui/gtk/extensions/shell_window_gtk.h

@@ -14,13 +14,15 @@

#include "ui/base/x/active_window_watcher_x_observer.h"

#include "ui/gfx/rect.h"

-class ExtensionHost;

+class Profile;

class ShellWindowGtk : public ShellWindow,

public ExtensionViewGtk::Container,

public ui::ActiveWindowWatcherXObserver {

public:

- explicit ShellWindowGtk(ExtensionHost* host);

+ explicit ShellWindowGtk(Profile* profile,

Evan Stade 2012/05/08 00:58:16 you only need explicit when there's exactly one pa

+ const Extension* extension,

+ const GURL& url);

// BaseWindow implementation.

virtual bool IsActive() const OVERRIDE;