Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Side by Side Diff: chrome/browser/ui/gtk/extensions/shell_window_gtk.h

Issue 10119003: Pull shell window stuff out of ExtensionHost and put in ShellWindow (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Comments Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_GTK_EXTENSIONS_SHELL_WINDOW_GTK_H_ 5 #ifndef CHROME_BROWSER_UI_GTK_EXTENSIONS_SHELL_WINDOW_GTK_H_
6 #define CHROME_BROWSER_UI_GTK_EXTENSIONS_SHELL_WINDOW_GTK_H_ 6 #define CHROME_BROWSER_UI_GTK_EXTENSIONS_SHELL_WINDOW_GTK_H_
7 #pragma once 7 #pragma once
8 8
9 #include <gtk/gtk.h> 9 #include <gtk/gtk.h>
10 10
11 #include "chrome/browser/ui/extensions/shell_window.h" 11 #include "chrome/browser/ui/extensions/shell_window.h"
12 #include "chrome/browser/ui/gtk/extensions/extension_view_gtk.h" 12 #include "chrome/browser/ui/gtk/extensions/extension_view_gtk.h"
13 #include "ui/base/gtk/gtk_signal.h" 13 #include "ui/base/gtk/gtk_signal.h"
14 #include "ui/base/x/active_window_watcher_x_observer.h" 14 #include "ui/base/x/active_window_watcher_x_observer.h"
15 #include "ui/gfx/rect.h" 15 #include "ui/gfx/rect.h"
16 16
17 class ExtensionHost; 17 class Profile;
18 18
19 class ShellWindowGtk : public ShellWindow, 19 class ShellWindowGtk : public ShellWindow,
20 public ExtensionViewGtk::Container, 20 public ExtensionViewGtk::Container,
21 public ui::ActiveWindowWatcherXObserver { 21 public ui::ActiveWindowWatcherXObserver {
22 public: 22 public:
23 explicit ShellWindowGtk(ExtensionHost* host); 23 explicit ShellWindowGtk(Profile* profile,
Evan Stade 2012/05/08 00:58:16 you only need explicit when there's exactly one pa
24 const Extension* extension,
25 const GURL& url);
24 26
25 // BaseWindow implementation. 27 // BaseWindow implementation.
26 virtual bool IsActive() const OVERRIDE; 28 virtual bool IsActive() const OVERRIDE;
27 virtual bool IsMaximized() const OVERRIDE; 29 virtual bool IsMaximized() const OVERRIDE;
28 virtual bool IsMinimized() const OVERRIDE; 30 virtual bool IsMinimized() const OVERRIDE;
29 virtual bool IsFullscreen() const OVERRIDE; 31 virtual bool IsFullscreen() const OVERRIDE;
30 virtual gfx::Rect GetRestoredBounds() const OVERRIDE; 32 virtual gfx::Rect GetRestoredBounds() const OVERRIDE;
31 virtual gfx::Rect GetBounds() const OVERRIDE; 33 virtual gfx::Rect GetBounds() const OVERRIDE;
32 virtual void Show() OVERRIDE; 34 virtual void Show() OVERRIDE;
33 virtual void ShowInactive() OVERRIDE; 35 virtual void ShowInactive() OVERRIDE;
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
66 // The position and size of the current window. 68 // The position and size of the current window.
67 gfx::Rect bounds_; 69 gfx::Rect bounds_;
68 70
69 // The position and size of the non-maximized, non-fullscreen window. 71 // The position and size of the non-maximized, non-fullscreen window.
70 gfx::Rect restored_bounds_; 72 gfx::Rect restored_bounds_;
71 73
72 DISALLOW_COPY_AND_ASSIGN(ShellWindowGtk); 74 DISALLOW_COPY_AND_ASSIGN(ShellWindowGtk);
73 }; 75 };
74 76
75 #endif // CHROME_BROWSER_UI_GTK_EXTENSIONS_SHELL_WINDOW_GTK_H_ 77 #endif // CHROME_BROWSER_UI_GTK_EXTENSIONS_SHELL_WINDOW_GTK_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698