Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 10107019: Fixes bug where button borders are not always painted in High DPI mode (Closed)

Created:
8 years, 8 months ago by pkotwicz
Modified:
8 years, 8 months ago
Reviewers:
sky, Rick Byers, reed1
CC:
chromium-reviews, tfarina, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Fixes bug where button borders are not always painted in high DPI mode. BUG=116553 TEST=Manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133459

Patch Set 1 #

Patch Set 2 : Changes as requested #

Patch Set 3 : Changes as requested #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -22 lines) Patch
M ui/gfx/native_theme_base.cc View 1 2 3 chunks +9 lines, -22 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
pkotwicz
This is a short CL just fixing buttons. The problem of 1 px borders not ...
8 years, 8 months ago (2012-04-17 15:02:53 UTC) #1
reed1
I'd like to better understand the bug. At a glance this change is a little ...
8 years, 8 months ago (2012-04-17 15:35:15 UTC) #2
pkotwicz
Changed the code to use antialiasing in drawing rounded rect. Also changed to use of ...
8 years, 8 months ago (2012-04-17 21:14:10 UTC) #3
reed1
Do you want to inset the rect by 1/2 of the stroke width before you ...
8 years, 8 months ago (2012-04-17 21:16:34 UTC) #4
reed1
... or is the intention to draw a little outside and a little inside of ...
8 years, 8 months ago (2012-04-17 21:17:09 UTC) #5
pkotwicz
Inset border as requested. Antialiasing both fill and border. (I think it is necessary to ...
8 years, 8 months ago (2012-04-18 18:19:30 UTC) #6
pkotwicz
Ping
8 years, 8 months ago (2012-04-21 23:12:54 UTC) #7
reed1
lgtm
8 years, 8 months ago (2012-04-23 12:08:56 UTC) #8
pkotwicz
Sky for OWNERS
8 years, 8 months ago (2012-04-23 12:53:31 UTC) #9
sky
LGTM
8 years, 8 months ago (2012-04-23 15:01:32 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pkotwicz@chromium.org/10107019/8001
8 years, 8 months ago (2012-04-23 15:02:14 UTC) #11
commit-bot: I haz the power
8 years, 8 months ago (2012-04-23 16:23:15 UTC) #12
Change committed as 133459

Powered by Google App Engine
This is Rietveld 408576698