content/browser/geolocation/geolocation_provider.h - Issue 10103029: Add device location reporting

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/geolocation/geolocation_provider.h

Issue 10103029: Add device location reporting (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/geolocation/geolocation_provider.h

diff --git a/content/browser/geolocation/geolocation_provider.h b/content/browser/geolocation/geolocation_provider.h

index a45a365f23066aa71491b65ce8aa07e7f05cb629..c340e57256e7798cf971bf568c4d1e3d86f8f0e3 100644

--- a/content/browser/geolocation/geolocation_provider.h

+++ b/content/browser/geolocation/geolocation_provider.h

@@ -56,10 +56,11 @@ class CONTENT_EXPORT GeolocationProvider

typedef std::map<GeolocationObserver*, GeolocationObserverOptions>

ObserverMap;

- private:

+ protected:

friend struct DefaultSingletonTraits<GeolocationProvider>;

Joao da Silva 2012/04/20 09:49:57 I'm not familiar with this code, but a singleton w

John Knottenbelt 2012/04/20 12:50:42 Agree. On 2012/04/20 09:49:57, Joao da Silva wrot

bartfab (slow) 2012/04/20 14:10:15 Done.

virtual ~GeolocationProvider();

+ private:

bool OnClientThread() const;

bool OnGeolocationThread() const;