Add device location reporting

content/browser/geolocation/geolocation_provider.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_GEOLOCATION_GEOLOCATION_PROVIDER_H_
 #define CONTENT_BROWSER_GEOLOCATION_GEOLOCATION_PROVIDER_H_
 #pragma once
 
 #include <map>
 
@@ skipping 38 matching lines @@
   virtual void OnLocationUpdate(const Geoposition& position) OVERRIDE;
 
   // Gets a pointer to the singleton instance of the location relayer, which
   // is in turn bound to the browser's global context objects. Ownership is NOT
   // returned.
   static GeolocationProvider* GetInstance();
 
   typedef std::map<GeolocationObserver*, GeolocationObserverOptions>
       ObserverMap;
 
- private:
+ protected:
   friend struct DefaultSingletonTraits<GeolocationProvider>;

[Joao da Silva, 2012/04/20 09:49:57]

I'm not familiar with this code, but a singleton with a GetInstace() method
should also have a protected/private ctor.

[John Knottenbelt, 2012/04/20 12:50:42]

Agree.

On 2012/04/20 09:49:57, Joao da Silva wrote:

[bartfab (slow), 2012/04/20 14:10:15]

Done.

   virtual ~GeolocationProvider();
 
+ private:
   bool OnClientThread() const;
   bool OnGeolocationThread() const;
 
   // When the observer list changes, we may start the thread and the required
   // providers, or stop them.
   void OnObserversChanged();
 
   // Stop the providers when there are no more observers. Note that once our
   // thread is started, we'll keep it alive (but with no pending messages).
   void StopProviders();
@@ skipping 19 matching lines @@
   bool is_permission_granted_;
   Geoposition position_;
 
   // Only to be used on the geolocation thread.
   GeolocationArbitrator* arbitrator_;
 
   DISALLOW_COPY_AND_ASSIGN(GeolocationProvider);
 };
 
 #endif  // CONTENT_BROWSER_GEOLOCATION_GEOLOCATION_PROVIDER_H_