Issue 10094003: I accidentally converted a DCHECK to a CHECK when I landed r132303

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10094003: I accidentally converted a DCHECK to a CHECK when I landed r132303 (Closed)

Created:
8 years, 8 months ago by jschuh

Modified:
8 years, 8 months ago

Reviewers:

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
https://src.chromium.org/svn/trunk/src/

Visibility:
Public.

I accidentally converted a DCHECK to a CHECK when I landed r132303 Apparently it really should be a DCHECK. TBR=jam@chromium.org BUG=123495 BUG=119250 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132356

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/webplugin_delegate_proxy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 2 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jschuh@chromium.org/10094003/1

8 years, 8 months ago (2012-04-15 02:40:10 UTC) #1

Change committed as 132356