Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(622)

Unified Diff: skia/ext/platform_canvas_skia.cc

Issue 10093006: Fix win32 error checking in platform_canvas_skia.cc by moving code into ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove reduction of code duplication from patch as there's still some uncertainty about how to best… Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « skia/ext/bitmap_platform_device_win.cc ('k') | skia/ext/platform_canvas_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: skia/ext/platform_canvas_skia.cc
diff --git a/skia/ext/platform_canvas_skia.cc b/skia/ext/platform_canvas_skia.cc
index 258f119b22143b5d75a06010b76cc2111b28138c..9cd51aca417dfe660a0cf8e3aeb2e42a48be89d3 100644
--- a/skia/ext/platform_canvas_skia.cc
+++ b/skia/ext/platform_canvas_skia.cc
@@ -68,17 +68,9 @@ bool PlatformCanvas::initialize(int width,
bool is_opaque,
HANDLE shared_section) {
// Use platform specific device for shared_section.
- if (shared_section) {
- if (initializeWithDevice(BitmapPlatformDevice::Create(width,
- height,
- is_opaque,
- shared_section)))
- return true;
-
- // TODO(reveman): move the failure investigation from
- // platform_canvas_win.cc to bitmap_platform_device_win.cc.
- return false;
- }
+ if (shared_section)
+ return initializeWithDevice(BitmapPlatformDevice::Create(
+ width, height, is_opaque, shared_section));
return initializeWithDevice(new SkDevice(
SkBitmap::kARGB_8888_Config, width, height, is_opaque));
« no previous file with comments | « skia/ext/bitmap_platform_device_win.cc ('k') | skia/ext/platform_canvas_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698