Fix win32 error checking in platform_canvas_skia.cc by moving code into ...

Fix win32 error checking in platform_canvas_skia.cc by moving code into bitmap_platform_device_win.cc.

BUG=119555
TEST=manual

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132550

[reveman, 2012-04-16 16:16:40]

Hi, here's the cleanup I promised after introducing platform_canvas_skia.cc for
m19.

[Alexei Svitkine (slow), 2012-04-16 19:01:44]

http://codereview.chromium.org/10093006/diff/1/skia/ext/bitmap_platform_devic...
File skia/ext/bitmap_platform_device_win.cc (right):

http://codereview.chromium.org/10093006/diff/1/skia/ext/bitmap_platform_devic...
skia/ext/bitmap_platform_device_win.cc:189:
CrashForBitmapAllocationFailure(width, height, error);
Can you explain why it makes sense to move this here? Is this the only way
initializeWithDevice() can fail?

Can you also CC whoever added this code since I'm assuming it's related to an
issue currently being debugged.

http://codereview.chromium.org/10093006/diff/1/skia/ext/platform_canvas.h
File skia/ext/platform_canvas.h (right):

http://codereview.chromium.org/10093006/diff/1/skia/ext/platform_canvas.h#new...
skia/ext/platform_canvas.h:18: #else
Shouldn't you have this:

#elif defined(__APPLE__)
typedef CGContextRef PlatformData;

Instead of the #if defined(__APPLE__) section below?

http://codereview.chromium.org/10093006/diff/1/skia/ext/platform_canvas.h#new...
skia/ext/platform_canvas.h:35: // @height * StrideForWidth(@width) bytes.
Nit: Use pairs of |'s instead of @'s for param names. Also, place the the third
sentence on a new line - otherwise the line breaking looks strange.

[Alexei Svitkine (slow), 2012-04-16 20:18:42]

Thanks. LGTM if you address my two nits (one from this comment and the one from
the previous).

http://codereview.chromium.org/10093006/diff/1/skia/ext/platform_canvas_skia.cc
File skia/ext/platform_canvas_skia.cc (right):

http://codereview.chromium.org/10093006/diff/1/skia/ext/platform_canvas_skia....
skia/ext/platform_canvas_skia.cc:50: if
(initializeWithDevice(BitmapPlatformDevice::Create(width,
Nit: Just return initializeWithDevice(...).

[commit-bot: I haz the power, 2012-04-17 05:16:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/reveman@chromium.org/10093006/7008

[commit-bot: I haz the power, 2012-04-17 08:00:43]

Change committed as 132550