Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10086011: [Chrome OS ECHO]: Rename API and method names (Closed)

Created:
8 years, 8 months ago by gauravsh
Modified:
8 years, 8 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, mihaip+watch_chromium.org, Aaron Boodman, arv (Not doing code reviews), stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

[Chrome OS ECHO]: Rename API and method names In addition, get rid of one API method that is no longer used. BUG=chromium-os:28507 TEST=existing (renamed) unit tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132700

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : address tbarzic's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -442 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/chromeos/extensions/echo_private_api.h View 1 chunk +22 lines, -0 lines 0 comments Download
A chrome/browser/chromeos/extensions/echo_private_api.cc View 1 2 1 chunk +49 lines, -0 lines 0 comments Download
A + chrome/browser/chromeos/extensions/echo_private_apitest.cc View 1 chunk +3 lines, -3 lines 0 comments Download
D chrome/browser/chromeos/extensions/offers_private_api.h View 1 chunk +0 lines, -41 lines 0 comments Download
D chrome/browser/chromeos/extensions/offers_private_api.cc View 1 chunk +0 lines, -206 lines 0 comments Download
D chrome/browser/chromeos/extensions/offers_private_apitest.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M chrome/browser/chromeos/system/statistics_provider.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/extensions/component_loader.cc View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/browser/extensions/extension_function_registry.cc View 1 2 chunks +3 lines, -4 lines 0 comments Download
A + chrome/browser/resources/chromeos/echo/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/resources/chromeos/echo/manifest.json View 2 chunks +2 lines, -2 lines 0 comments Download
D chrome/browser/resources/chromeos/offers/OWNERS View 1 chunk +0 lines, -2 lines 0 comments Download
D chrome/browser/resources/chromeos/offers/manifest.json View 1 chunk +0 lines, -28 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/chrome_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/chrome_switches.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/api/_permission_features.json View 1 1 chunk +1 line, -1 line 0 comments Download
A + chrome/common/extensions/api/echoPrivate.json View 2 chunks +2 lines, -20 lines 0 comments Download
M chrome/common/extensions/api/extension_api.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
D chrome/common/extensions/api/offersPrivate.json View 1 chunk +0 lines, -55 lines 0 comments Download
M chrome/common/extensions/extension_permission_set.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_permission_set_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions_api_resources.grd View 1 2 chunks +1 line, -1 line 0 comments Download
A + chrome/test/data/extensions/api_test/echo/component_extension/manifest.json View 1 chunk +3 lines, -3 lines 0 comments Download
A + chrome/test/data/extensions/api_test/echo/component_extension/test.js View 1 chunk +6 lines, -6 lines 0 comments Download
D chrome/test/data/extensions/api_test/offers/component_extension/manifest.json View 1 chunk +0 lines, -10 lines 0 comments Download
D chrome/test/data/extensions/api_test/offers/component_extension/test.js View 1 chunk +0 lines, -23 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
gauravsh
This is mainly a renaming change that in addition gets rid of one private api ...
8 years, 8 months ago (2012-04-13 20:23:58 UTC) #1
gauravsh
Toni/Steven: ping?
8 years, 8 months ago (2012-04-17 17:52:32 UTC) #2
tbarzic
http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc File chrome/browser/chromeos/extensions/echo_private_api.cc (right): http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc#newcode26 chrome/browser/chromeos/extensions/echo_private_api.cc:26: #include "content/public/browser/notification_details.h" includes could use some cleanup :) http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc#newcode68 ...
8 years, 8 months ago (2012-04-17 18:23:04 UTC) #3
gauravsh
http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc File chrome/browser/chromeos/extensions/echo_private_api.cc (right): http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc#newcode26 chrome/browser/chromeos/extensions/echo_private_api.cc:26: #include "content/public/browser/notification_details.h" On 2012/04/17 18:23:04, tbarzic wrote: > includes ...
8 years, 8 months ago (2012-04-17 19:05:51 UTC) #4
tbarzic
On 2012/04/17 19:05:51, gauravsh wrote: > http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc > File chrome/browser/chromeos/extensions/echo_private_api.cc (right): > > http://codereview.chromium.org/10086011/diff/3001/chrome/browser/chromeos/extensions/echo_private_api.cc#newcode26 > ...
8 years, 8 months ago (2012-04-17 19:33:21 UTC) #5
gauravsh
asargent: chrome/common/extensions/api/ OWNER xiyuan: chrome/browser/resources/chromeos/ OWNER
8 years, 8 months ago (2012-04-17 20:05:31 UTC) #6
xiyuan
rubber stamp LGTM
8 years, 8 months ago (2012-04-17 21:03:53 UTC) #7
asargent_no_longer_on_chrome
lgtm ("echo" seems like some sort of project code name or something and does not ...
8 years, 8 months ago (2012-04-17 21:36:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/gauravsh@chromium.org/10086011/8001
8 years, 8 months ago (2012-04-17 21:39:08 UTC) #9
commit-bot: I haz the power
8 years, 8 months ago (2012-04-17 23:52:17 UTC) #10 
Change committed as 132700

Powered by Google App Engine
This is Rietveld 408576698