[Chrome OS ECHO]: Rename API and method names

chrome/browser/chromeos/extensions/echo_private_api.cc

+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/chromeos/extensions/echo_private_api.h"
+
+#include <string>
+
+#include "base/compiler_specific.h"
+#include "base/logging.h"
+#include "base/memory/scoped_ptr.h"
+#include "base/values.h"
+#include "chrome/browser/chromeos/system/statistics_provider.h"
+#include "chrome/browser/extensions/extension_host.h"
+#include "chrome/browser/extensions/extension_process_manager.h"
+#include "chrome/browser/extensions/extension_tab_util.h"
+#include "chrome/browser/extensions/extension_window_controller.h"
+#include "chrome/browser/infobars/infobar_tab_helper.h"
+#include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/tab_contents/confirm_infobar_delegate.h"
+#include "chrome/browser/ui/browser.h"
+#include "chrome/browser/ui/browser_list.h"
+#include "chrome/browser/ui/tab_contents/tab_contents_wrapper.h"
+#include "chrome/common/chrome_notification_types.h"
+#include "chrome/common/extensions/extension.h"
+#include "content/public/browser/notification_details.h"

[tbarzic, 2012/04/17 18:23:04]

includes could use some cleanup :)

[gauravsh, 2012/04/17 19:05:52]

Done.

+#include "content/public/browser/notification_observer.h"
+#include "content/public/browser/notification_registrar.h"
+#include "content/public/browser/notification_source.h"
+#include "content/public/browser/web_contents.h"
+#include "grit/generated_resources.h"
+#include "ui/base/l10n/l10n_util.h"
+
+namespace {
+
+// For a given registration code type, returns the code value from the
+// underlying system.
+std::string GetValueForRegistrationCodeType(std::string& type) {
+  // Possible ECHO code type and corresponding key name in StatisticsProvider.
+  const std::string kCouponType = "COUPON_CODE";
+  const std::string kCouponCodeKey = "ubind_attribute";
+  const std::string kGroupType = "GROUP_CODE";
+  const std::string kGroupCodeKey = "gbind_attribute";
+
+  chromeos::system::StatisticsProvider* provider =
+      chromeos::system::StatisticsProvider::GetInstance();
+  std::string result;
+  if (type == kCouponType)
+    provider->GetMachineStatistic(kCouponCodeKey, &result);
+  else if (type == kGroupType)
+    provider->GetMachineStatistic(kGroupCodeKey, &result);
+  return result;
+}
+
+}  // namespace
+
+
+GetRegistrationCodeFunction::GetRegistrationCodeFunction() {
+}
+
+GetRegistrationCodeFunction::~GetRegistrationCodeFunction() {
+}
+
+bool GetRegistrationCodeFunction::RunImpl() {
+  std::string type;
+  EXTENSION_FUNCTION_VALIDATE(args_->GetString(0, &type));
+  result_.reset(Value::CreateStringValue(
+      GetValueForRegistrationCodeType(type)));

[tbarzic, 2012/04/17 18:23:04]

This would probably look nicer if GetValueForRegistrationCode returned
base::Value* instead of std::string

[gauravsh, 2012/04/17 19:05:52]

Done.

+  return true;
+}