views: Create update recommended dialog inside the Show() function.

chrome/browser/ui/views/update_recommended_message_box.h

Index: chrome/browser/ui/views/update_recommended_message_box.h
diff --git a/chrome/browser/ui/views/update_recommended_message_box.h b/chrome/browser/ui/views/update_recommended_message_box.h
index 79a6229aab56c9e22e78fae4f7f6be19518a1033..95ad6127e2f3c1944f423bcad1cbad03401efb22 100644
--- a/chrome/browser/ui/views/update_recommended_message_box.h
+++ b/chrome/browser/ui/views/update_recommended_message_box.h
@@ -18,14 +18,14 @@ class MessageBoxView;
 // the latest version to be put to use.
 class UpdateRecommendedMessageBox : public views::DialogDelegate {
  public:
-  // This box is modal to |parent_window|.
-  static void ShowMessageBox(gfx::NativeWindow parent_window);
+  static void Show(gfx::NativeWindow parent_window);
 
-  // Overridden from views::DialogDelegate:
-  virtual bool Accept() OVERRIDE;
+ private:
+  explicit UpdateRecommendedMessageBox();

[Peter Kasting, 2012/04/13 21:45:37]

Nit: No explicit on 0-arg constructors

+  virtual ~UpdateRecommendedMessageBox();
 
- protected:
   // Overridden from views::DialogDelegate:
+  virtual bool Accept() OVERRIDE;
   virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
 
   // Overridden from views::WidgetDelegate:
@@ -37,10 +37,6 @@ class UpdateRecommendedMessageBox : public views::DialogDelegate {
   virtual views::Widget* GetWidget() OVERRIDE;
   virtual const views::Widget* GetWidget() const OVERRIDE;
 
- private:
-  explicit UpdateRecommendedMessageBox(gfx::NativeWindow parent_window);
-  virtual ~UpdateRecommendedMessageBox();
-
   views::MessageBoxView* message_box_view_;
 
   DISALLOW_COPY_AND_ASSIGN(UpdateRecommendedMessageBox);