views: Create update recommended dialog inside the Show() function.

chrome/browser/ui/views/update_recommended_message_box.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_VIEWS_UPDATE_RECOMMENDED_MESSAGE_BOX_H_
 #define CHROME_BROWSER_UI_VIEWS_UPDATE_RECOMMENDED_MESSAGE_BOX_H_
 #pragma once
 
 #include "base/basictypes.h"
 #include "ui/gfx/native_widget_types.h"
 #include "ui/views/window/dialog_delegate.h"
 
 namespace views {
 class MessageBoxView;
 }
 
 // A dialog box that tells the user that an update is recommended in order for
 // the latest version to be put to use.
 class UpdateRecommendedMessageBox : public views::DialogDelegate {
  public:
-  // This box is modal to |parent_window|.
-  static void ShowMessageBox(gfx::NativeWindow parent_window);
+  static void Show(gfx::NativeWindow parent_window);
+
+ private:
+  explicit UpdateRecommendedMessageBox();

[Peter Kasting, 2012/04/13 21:45:37]

Nit: No explicit on 0-arg constructors

+  virtual ~UpdateRecommendedMessageBox();
 
   // Overridden from views::DialogDelegate:
   virtual bool Accept() OVERRIDE;
-
- protected:
-  // Overridden from views::DialogDelegate:
   virtual string16 GetDialogButtonLabel(ui::DialogButton button) const OVERRIDE;
 
   // Overridden from views::WidgetDelegate:
   virtual bool ShouldShowWindowTitle() const OVERRIDE;
   virtual string16 GetWindowTitle() const OVERRIDE;
   virtual void DeleteDelegate() OVERRIDE;
   virtual ui::ModalType GetModalType() const OVERRIDE;
   virtual views::View* GetContentsView() OVERRIDE;
   virtual views::Widget* GetWidget() OVERRIDE;
   virtual const views::Widget* GetWidget() const OVERRIDE;
 
- private:
-  explicit UpdateRecommendedMessageBox(gfx::NativeWindow parent_window);
-  virtual ~UpdateRecommendedMessageBox();
-
   views::MessageBoxView* message_box_view_;
 
   DISALLOW_COPY_AND_ASSIGN(UpdateRecommendedMessageBox);
 };
 
 #endif  // CHROME_BROWSER_UI_VIEWS_UPDATE_RECOMMENDED_MESSAGE_BOX_H_