Issue 10084023: views: Create update recommended dialog inside the Show() function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10084023: views: Create update recommended dialog inside the Show() function. (Closed)

Created:
8 years, 8 months ago by tfarina

Modified:
8 years, 8 months ago

Reviewers:
Peter Kasting

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

views: Create update recommended dialog inside the Show() function. This patch makes UpdateRecommendedMessageBox more cleaner. R=pkasting@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132335

Patch Set 1 #

Total comments: 3

Patch Set 2 : peter review #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -42 lines)			Patch
M	chrome/browser/ui/views/frame/browser_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/update_recommended_message_box.h	View	1	2 chunks	+5 lines, -9 lines	0 comments	Download
M	chrome/browser/ui/views/update_recommended_message_box.cc	View	1	4 chunks	+25 lines, -32 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Peter Kasting

8 years, 8 months ago (2012-04-13 21:45:37 UTC) #2

LGTM

http://codereview.chromium.org/10084023/diff/1/chrome/browser/ui/views/update...
File chrome/browser/ui/views/update_recommended_message_box.cc (right):

http://codereview.chromium.org/10084023/diff/1/chrome/browser/ui/views/update...
chrome/browser/ui/views/update_recommended_message_box.cc:21: #if
defined(OS_CHROMEOS)
Nit: I think defining these in the function body (as before) is better when
they're only used in one place.

http://codereview.chromium.org/10084023/diff/1/chrome/browser/ui/views/update...
chrome/browser/ui/views/update_recommended_message_box.cc:37:
UpdateRecommendedMessageBox* window = new UpdateRecommendedMessageBox;
Nit: Can inline into the next line.

I also suggest adding "()" to the classname when constructing, although there's
no style rule about this.

http://codereview.chromium.org/10084023/diff/1/chrome/browser/ui/views/update...
File chrome/browser/ui/views/update_recommended_message_box.h (right):

http://codereview.chromium.org/10084023/diff/1/chrome/browser/ui/views/update...
chrome/browser/ui/views/update_recommended_message_box.h:24: explicit
UpdateRecommendedMessageBox();
Nit: No explicit on 0-arg constructors

Expand Messages | Collapse Messages