Aura/ash split: Remove hacks and get chrome linking without ash.

Recommitting Aura/ash split: Remove hacks and get chrome linking without ash.

This changes TestViewsDelegate::CreateNativeWidgetHelper to always return NULL, and for views_examples_exe to use its own subclass that create the desktop implementation.

For the first time now, you can do:

    > build/gyp_chromium -Duse_aura=1 -Duse_ash=0

And get a running chrome. It has lots of issues, especially related to
window placement, tab handling, etc, but it pops up and renders web content.

Also consolidates most of the desktop behavior into its own class.

Also makes views_examples_exe work again. Several of the hacks are no longer
needed after Ben's refactoring to support WebView.

BUG=116458, 119759
TEST=none
First Review URL: http://codereview.chromium.org/10081022


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133105

[Elliot Glaysher, 2012-04-19 16:37:02]

"This changes TestViewsDelegate::CreateNativeWidgetHelper to always return NULL,
and for views_examples_exe to use its own subclass that create the desktop
implementation. "

[Ben Goodger (Google), 2012-04-19 18:26:57]

What changed?
-Ben

On Thu, Apr 19, 2012 at 9:37 AM, <erg@chromium.org> wrote:

> Reviewers: Ben Goodger (Google),
>
> Message:
> "This changes TestViewsDelegate::**CreateNativeWidgetHelper to always
> return NULL,
> and for views_examples_exe to use its own subclass that create the desktop
> implementation. "
>
> Description:
> Recommitting Aura/ash split: Remove hacks and get chrome linking without
> ash.
>
> This changes TestViewsDelegate::**CreateNativeWidgetHelper to always
> return NULL,
> and for views_examples_exe to use its own subclass that create the desktop
> implementation.
>
> For the first time now, you can do:
>
>    > build/gyp_chromium -Duse_aura=1 -Duse_ash=0
>
> And get a running chrome. It has lots of issues, especially related to
> window placement, tab handling, etc, but it pops up and renders web
> content.
>
> Also consolidates most of the desktop behavior into its own class.
>
> Also makes views_examples_exe work again. Several of the hacks are no
> longer
> needed after Ben's refactoring to support WebView.
>
> BUG=116458,119759
> TEST=none
> First Review URL:
http://codereview.chromium.**org/10081022<http://codereview.chromium.org/1008...
>
>
> Please review this at
http://codereview.chromium.**org/10083058/<http://codereview.chromium.org/100...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>  M chrome/browser/chrome_browser_**main_extra_parts_aura.h
>  M chrome/browser/chrome_browser_**main_extra_parts_aura.cc
>  A + chrome/browser/fullscreen_ash.**cc
>  M chrome/browser/fullscreen_**aura.cc
>  A + chrome/browser/ui/tabs/dock_**info_ash.cc
>  M chrome/browser/ui/tabs/dock_**info_aura.cc
>  M chrome/browser/ui/views/**accessibility_event_router_**
> views_unittest.cc
>  D chrome/browser/ui/views/ash/**color_chooser_aura.cc
>  M chrome/browser/ui/views/**bookmarks/bookmark_bar_view_**test.cc
>  M chrome/browser/ui/views/**chrome_views_delegate.h
>  M chrome/browser/ui/views/**chrome_views_delegate.cc
>  A + chrome/browser/ui/views/color_**chooser_aura.cc
>  M chrome/browser/ui/views/menu_**model_adapter_test.cc
>  M chrome/chrome_browser.gypi
>  M ui/aura/aura.gyp
>  A ui/aura/desktop/desktop_**stacking_client.h
>  A ui/aura/desktop/desktop_**stacking_client.cc
>  M ui/views/examples/content_**client/examples_browser_main_**parts.h
>  M ui/views/examples/content_**client/examples_browser_main_**parts.cc
>  M ui/views/test/test_views_**delegate.h
>  M ui/views/test/test_views_**delegate.cc
>  M ui/views/views.gyp
>  M ui/views/views_delegate.h
>  A ui/views/widget/desktop_**native_widget_helper_aura.h
>  A ui/views/widget/desktop_**native_widget_helper_aura.cc
>  M ui/views/widget/native_widget_**aura.h
>  M ui/views/widget/native_widget_**aura.cc
>  A ui/views/widget/native_widget_**helper_aura.h
>
>
>

[Elliot Glaysher, 2012-04-19 18:48:42]

Patch set 1 is equivalent to what I committed. Patch set 2 is everything that
changed. Specifically, the default behaviour for TestViewsDelegate is to return
a NULL helper, and make an ExamplesViewsDelegate that conditionally compiles the
non-ash code.

[Ben Goodger (Google), 2012-04-19 19:02:30]

LGTM

On Thu, Apr 19, 2012 at 11:48 AM, <erg@chromium.org> wrote:

> Patch set 1 is equivalent to what I committed. Patch set 2 is everything
> that
> changed. Specifically, the default behaviour for TestViewsDelegate is to
> return
> a NULL helper, and make an ExamplesViewsDelegate that conditionally
> compiles the
> non-ash code.
>
>
http://codereview.chromium.**org/10083058/<http://codereview.chromium.org/100...
>

[commit-bot: I haz the power, 2012-04-19 19:31:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10083058/31

[commit-bot: I haz the power, 2012-04-19 20:43:46]

Try job failure for 10083058-31 (retry) (retry) on mac_rel for step
"browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2012-04-19 20:47:52]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10083058/31

[commit-bot: I haz the power, 2012-04-19 21:51:50]

Try job failure for 10083058-31 (retry) on linux_rel for step "browser_tests".
It's a second try, previously, step "browser_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_rel&...

[commit-bot: I haz the power, 2012-04-19 22:36:37]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10083058/31

[commit-bot: I haz the power, 2012-04-20 00:48:33]

Change committed as 133105