Aura/ash split: Remove hacks and get chrome linking without ash.

Aura/ash split: Remove hacks and get chrome linking without ash.

For the first time now, you can do:

    > build/gyp_chromium -Duse_aura=1 -Duse_ash=0

And get a running chrome. It has lots of issues, especially related to
window placement, tab handling, etc, but it pops up and renders web content.

Also consolidates most of the desktop behavior into its own class.

Also makes views_examples_exe work again. Several of the hacks are no longer
needed after Ben's refactoring to support WebView.

BUG=116458, 119759
TEST=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132856

[Ben Goodger (Google), 2012-04-13 22:57:03]

http://codereview.chromium.org/10081022/diff/1/chrome/browser/chrome_browser_...
File chrome/browser/chrome_browser_main_extra_parts_aura.cc (right):

http://codereview.chromium.org/10081022/diff/1/chrome/browser/chrome_browser_...
chrome/browser/chrome_browser_main_extra_parts_aura.cc:21:
views::NativeWidgetAura::set_aura_desktop_hax();
can you give this a proper name at least?

http://codereview.chromium.org/10081022/diff/1/ui/aura/desktop/desktop_stacki...
File ui/aura/desktop/desktop_stacking_client.h (right):

http://codereview.chromium.org/10081022/diff/1/ui/aura/desktop/desktop_stacki...
ui/aura/desktop/desktop_stacking_client.h:17: class AURA_EXPORT
DesktopStackingClient : public client::StackingClient {
explain what this does

[Elliot Glaysher, 2012-04-16 19:31:04]

ptal. I've made a small change in the name; I'll work on factoring out an
interface next, but I want to bounce some ideas off your in person first about
what ownership model you prefer.

[Elliot Glaysher, 2012-04-16 22:06:43]

ptal, moved the hax code into its own class, conditionally compiled in.

Also, please give me a better name for DesktopNativeWidgetHelperAura. That class
name is hideous.

[Ben Goodger (Google), 2012-04-17 15:42:55]

http://codereview.chromium.org/10081022/diff/7005/ui/views/widget/desktop_nat...
File ui/views/widget/desktop_native_widget_helper_aura.h (right):

http://codereview.chromium.org/10081022/diff/7005/ui/views/widget/desktop_nat...
ui/views/widget/desktop_native_widget_helper_aura.h:23:
DesktopNatitveWidgetHelperAura(NativeWidgetAura* widget);
explicit
Native

http://codereview.chromium.org/10081022/diff/7005/ui/views/widget/desktop_nat...
ui/views/widget/desktop_native_widget_helper_aura.h:37: // zero. Otherwise, pass
through in_bounds.
Otherwise, returns |bounds|.

http://codereview.chromium.org/10081022/diff/7005/ui/views/widget/desktop_nat...
ui/views/widget/desktop_native_widget_helper_aura.h:51: };
DISALLOW_COP

http://codereview.chromium.org/10081022/diff/7005/ui/views/widget/native_widg...
File ui/views/widget/native_widget_aura.cc (right):

http://codereview.chromium.org/10081022/diff/7005/ui/views/widget/native_widg...
ui/views/widget/native_widget_aura.cc:137: #if defined(USE_ASH)
views is not allowed to know about ash.
instead, the views client needs to assign this. the easiest way to do this
probably is to expose a method on the ViewsDelegate that constructs an instance
of this object or NULL.

[Elliot Glaysher, 2012-04-17 22:54:09]

ptal. Used ViewsDelegate in implementation, trybots are pretty green.

[Ben Goodger (Google), 2012-04-17 23:42:45]

http://codereview.chromium.org/10081022/diff/22001/ui/views/test/test_views_d...
File ui/views/test/test_views_delegate.cc (right):

http://codereview.chromium.org/10081022/diff/22001/ui/views/test/test_views_d...
ui/views/test/test_views_delegate.cc:67: #if !defined(USE_ASH)
you can't have ash here either

[Elliot Glaysher, 2012-04-18 18:08:11]

ptal. Made TestViewsDelegate just return a NativeWidgetHelperAura by default;
The ash delegate, which inherits from TestViewsDelegate, overrides that method
to be NULL.

[Ben Goodger (Google), 2012-04-18 18:18:41]

Cool. Thanks for your patience. LGTM.

[commit-bot: I haz the power, 2012-04-18 18:28:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10081022/13032

[commit-bot: I haz the power, 2012-04-18 20:32:23]

Change committed as 132856