Clarify output from bisect-builds so that it's more clear what the

Clarify output from bisect-builds so that it's more clear what the
bad revision range is.

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=132695

[Nico, 2012-04-17 22:04:53]

This is Robert's script, he gets to decide how the UI should look :-)

http://codereview.chromium.org/10083029/diff/1/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/10083029/diff/1/tools/bisect-builds.py#newcode557
tools/bisect-builds.py:557: print '  ' + BUILD_VIEWVC_URL % rev
The scrollback from this will push the more interesting all-in-one-page urls too
far up I think.

[dmazzoni, 2012-04-17 22:21:30]

On 2012/04/17 22:04:53, Nico wrote:
> This is Robert's script, he gets to decide how the UI should look :-)
> 
> http://codereview.chromium.org/10083029/diff/1/tools/bisect-builds.py
> File tools/bisect-builds.py (right):
> 
>
http://codereview.chromium.org/10083029/diff/1/tools/bisect-builds.py#newcode557
> tools/bisect-builds.py:557: print '  ' + BUILD_VIEWVC_URL % rev
> The scrollback from this will push the more interesting all-in-one-page urls
too
> far up I think.

Everybody else doesn't have 100,000 lines of scrollback? :)

Robert, what would you think of deleting the link to viewvc? I think the build
dashboard link that shows all revisions should supercede it, right?

My concern is that showing a link to just one revision is quite confusing to the
uninitiated, it's easy to think that change must be the single error.

[Robert Sesek, 2012-04-17 22:22:20]

On 2012/04/17 22:21:30, Dominic Mazzoni wrote:
> On 2012/04/17 22:04:53, Nico wrote:
> > This is Robert's script, he gets to decide how the UI should look :-)
> > 
> > http://codereview.chromium.org/10083029/diff/1/tools/bisect-builds.py
> > File tools/bisect-builds.py (right):
> > 
> >
>
http://codereview.chromium.org/10083029/diff/1/tools/bisect-builds.py#newcode557
> > tools/bisect-builds.py:557: print '  ' + BUILD_VIEWVC_URL % rev
> > The scrollback from this will push the more interesting all-in-one-page urls
> too
> > far up I think.
> 
> Everybody else doesn't have 100,000 lines of scrollback? :)
> 
> Robert, what would you think of deleting the link to viewvc? I think the build
> dashboard link that shows all revisions should supercede it, right?
> 
> My concern is that showing a link to just one revision is quite confusing to
the
> uninitiated, it's easy to think that change must be the single error.

I'm for removing the single revision link, but I do not think we should print
ever revision's link. That's what the link to the changelog is for.

[dmazzoni, 2012-04-17 22:41:58]

OK, I got rid of the viewvc link, that keeps it simpler. How's this?

[Robert Sesek, 2012-04-17 23:12:48]

http://codereview.chromium.org/10083029/diff/3/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/10083029/diff/3/tools/bisect-builds.py#newcode19
tools/bisect-builds.py:19: BUILD_VIEWVC_URL =
'http://src.chromium.org/viewvc/chrome?view=rev&revision=%d'
Remove?

[dmazzoni, 2012-04-17 23:16:18]

http://codereview.chromium.org/10083029/diff/3/tools/bisect-builds.py
File tools/bisect-builds.py (right):

http://codereview.chromium.org/10083029/diff/3/tools/bisect-builds.py#newcode19
tools/bisect-builds.py:19: BUILD_VIEWVC_URL =
'http://src.chromium.org/viewvc/chrome?view=rev&revision=%d'
On 2012/04/17 23:12:48, rsesek wrote:
> Remove?

Done.

[Robert Sesek, 2012-04-17 23:17:07]

lgtm