Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Unified Diff: tools/bisect-builds.py

Issue 10083029: Clarify output from bisect-builds so that it's more clear what the (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/bisect-builds.py
===================================================================
--- tools/bisect-builds.py (revision 132659)
+++ tools/bisect-builds.py (working copy)
@@ -15,9 +15,6 @@
# The root URL for storage.
BASE_URL = 'http://commondatastorage.googleapis.com/chromium-browser-snapshots'
-# URL to the ViewVC commit page.
-BUILD_VIEWVC_URL = 'http://src.chromium.org/viewvc/chrome?view=rev&revision=%d'
-
# Changelogs URL.
CHANGELOG_URL = 'http://build.chromium.org/f/chromium/' \
'perf/dashboard/ui/changelog.html?url=/trunk/src&range=%d:%d'
@@ -29,6 +26,9 @@
WEBKIT_CHANGELOG_URL = 'http://trac.webkit.org/log/' \
'trunk/?rev=%d&stop_rev=%d&verbose=on'
+DONE_MESSAGE = 'You are probably looking for a change made after ' \
+ '%d (known good), but no later than %d (first known bad).'
+
###############################################################################
import math
@@ -542,16 +542,13 @@
last_known_good_webkit_rev, first_known_bad_webkit_rev = 0, 0
# We're done. Let the user know the results in an official manner.
- print('You are probably looking for build %d.' % first_known_bad_rev)
+ print DONE_MESSAGE % (last_known_good_rev, first_known_bad_rev)
+ print 'CHANGELOG URL:'
+ print ' ' + CHANGELOG_URL % (last_known_good_rev, first_known_bad_rev)
if last_known_good_webkit_rev != first_known_bad_webkit_rev:
print 'WEBKIT CHANGELOG URL:'
- print WEBKIT_CHANGELOG_URL % (first_known_bad_webkit_rev,
- last_known_good_webkit_rev)
- print 'CHANGELOG URL:'
- print CHANGELOG_URL % (last_known_good_rev, first_known_bad_rev)
- print 'Built at revision:'
- print BUILD_VIEWVC_URL % first_known_bad_rev
+ print ' ' + WEBKIT_CHANGELOG_URL % (first_known_bad_webkit_rev,
+ last_known_good_webkit_rev)
-
if __name__ == '__main__':
sys.exit(main())
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698