chrome/browser/extensions/api/runtime/runtime_api.cc - Issue 10082019: Have LazyBackgroundTaskQueue notify consumers when the transient page fails to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/runtime/runtime_api.cc

Issue 10082019: Have LazyBackgroundTaskQueue notify consumers when the transient page fails to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/extensions/api/runtime/runtime_api.cc

diff --git a/chrome/browser/extensions/api/runtime/runtime_api.cc b/chrome/browser/extensions/api/runtime/runtime_api.cc

index 544e064ac42b18472f5194d805a70753b8a680f2..bcffb0f483df8276e3b3a2002a184ad8dcb6d48a 100644

--- a/chrome/browser/extensions/api/runtime/runtime_api.cc

+++ b/chrome/browser/extensions/api/runtime/runtime_api.cc

@@ -56,8 +56,9 @@ bool RuntimeGetBackgroundPageFunction::RunImpl() {

return true;

}

-void RuntimeGetBackgroundPageFunction::OnPageLoaded(ExtensionHost*) {

- SendResponse(true);

+void RuntimeGetBackgroundPageFunction::OnPageLoaded(ExtensionHost* host) {

+ if (host)

Yoyo Zhou 2012/04/13 20:43:52 If not, it looks like the async function will neve

Matt Perry 2012/04/13 21:19:09 Good catch, fixed!

+ SendResponse(true);

}

} // namespace extensions

« no previous file with comments | « no previous file | chrome/browser/extensions/extension_event_router.cc » ('j') | chrome/browser/extensions/lazy_background_task_queue.cc » ('J')