Issue 10082011: Remove unnecessary renames from dartdomgenerator.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10082011: Remove unnecessary renames from dartdomgenerator.py. (Closed)

Created:
8 years, 8 months ago by podivilov

Modified:
8 years, 8 months ago

Reviewers:
antonm, Anton Muhin, sra

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Remove unnecessary renames from dartdomgenerator.py. AbstractView is not referenced by other idls so we can just ignore AbstractView.idl like v8 bindings do. Function -> EventListener rename also doesn't affect anything. R=sra@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6676

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+5 lines, -12 lines)			Patch
M	lib/dom/scripts/dartdomgenerator.py	View	1 chunk	+0 lines, -6 lines	1 comment	Download
M	lib/dom/scripts/databasebuilder.py	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	lib/dom/scripts/fremontcutbuilder.py	View	2 chunks	+5 lines, -1 line	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Anton Muhin

8 years, 8 months ago (2012-04-17 10:57:59 UTC) #2

LGTM!

http://codereview.chromium.org/10082011/diff/1/lib/dom/scripts/dartdomgenerat...
File lib/dom/scripts/dartdomgenerator.py (left):

http://codereview.chromium.org/10082011/diff/1/lib/dom/scripts/dartdomgenerat...
lib/dom/scripts/dartdomgenerator.py:89: generator.RenameTypes(common_database, {
nice!

http://codereview.chromium.org/10082011/diff/1/lib/dom/scripts/fremontcutbuil...
File lib/dom/scripts/fremontcutbuilder.py (left):

http://codereview.chromium.org/10082011/diff/1/lib/dom/scripts/fremontcutbuil...
lib/dom/scripts/fremontcutbuilder.py:201: if ext == '.idl' and not
name.startswith('._'):
I am sure you thought about that, but is it safe to remove now?

Expand Messages | Collapse Messages