Issue 10081014: 1st phasing of transition to new API.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10081014: 1st phasing of transition to new API. (Closed)

Created:
8 years, 8 months ago by Anton Muhin

Modified:
8 years, 8 months ago

Reviewers:
podivilov

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

1st phasing of transition to new API. Now list of files should be passed directly, and not via some artificial file. R=podivilov@chromium.org Committed: https://code.google.com/p/dart/source/detail?r=6562

Patch Set 1 #

Total comments: 2

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -14 lines)			Patch
	M	lib/dom/scripts/fremontcutbuilder.py	View		5 chunks	+14 lines, -14 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

podivilov

lgtm http://codereview.chromium.org/10081014/diff/1/lib/dom/scripts/fremontcutbuilder.py File lib/dom/scripts/fremontcutbuilder.py (right): http://codereview.chromium.org/10081014/diff/1/lib/dom/scripts/fremontcutbuilder.py#newcode137 lib/dom/scripts/fremontcutbuilder.py:137: idl_list_file = open(idl_files, 'r') Is it needed for ...

8 years, 8 months ago (2012-04-16 09:24:58 UTC) #2

Anton Muhin

8 years, 8 months ago (2012-04-16 09:39:37 UTC) #3

http://codereview.chromium.org/10081014/diff/1/lib/dom/scripts/fremontcutbuil...
File lib/dom/scripts/fremontcutbuilder.py (right):

http://codereview.chromium.org/10081014/diff/1/lib/dom/scripts/fremontcutbuil...
lib/dom/scripts/fremontcutbuilder.py:137: idl_list_file = open(idl_files, 'r')
On 2012/04/16 09:24:58, podivilov wrote:
> Is it needed for two-side patching only?

Sorry?  I just do not want to make breaking changes if I can

Expand Messages | Collapse Messages