Issue 10080018: Don't allow sending data URLs to WebUI, unless in a ChromeOS BalloonHost.

Issue 10080018: Don't allow sending data URLs to WebUI, unless in a ChromeOS BalloonHost. (Closed)

Created:
8 years, 8 months ago by Charlie Reis

Modified:
8 years, 8 months ago

Reviewers:
jam, Evan Stade

CC:
chromium-reviews, joi+watch-content_chromium.org, jam, darin-cc_chromium.org, creis+watch_chromium.org, ajwong+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Don't allow sending data URLs to WebUI, unless in a ChromeOS BalloonHost. BUG=123428 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=132459

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -15 lines)			Patch
M	chrome/browser/notifications/balloon_host.h	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/notifications/balloon_host.cc	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc	View	1	2 chunks	+7 lines, -2 lines	0 comments	Download
M	content/browser/site_instance_impl_unittest.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/render_view_host_manager.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/browser/web_contents/render_view_host_manager_unittest.cc	View		1 chunk	+4 lines, -2 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl.cc	View	1	1 chunk	+4 lines, -5 lines	0 comments	Download
M	content/browser/web_contents/web_contents_impl_unittest.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	content/public/browser/web_contents_delegate.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/public/browser/web_contents_delegate.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	content/public/browser/web_ui_controller_factory.h	View		1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 8 (0 generated)

Charlie Reis

Evan, can you review for chrome/ui/webui owners approval? John, I fixed a few compile errors ...

8 years, 8 months ago (2012-04-16 14:41:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/10080018/6001

8 years, 8 months ago (2012-04-16 18:30:40 UTC) #5

commit-bot: I haz the power

Try job failure for 10080018-6001 (retry) on linux_rel for step "compile" (clobber build). It's a ...

8 years, 8 months ago (2012-04-16 19:06:35 UTC) #6

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/creis@chromium.org/10080018/6001

8 years, 8 months ago (2012-04-16 19:14:02 UTC) #7

Change committed as 132459