content/browser/web_contents/render_view_host_manager.cc - Issue 10080018: Don't allow sending data URLs to WebUI, unless in a ChromeOS BalloonHost.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/render_view_host_manager.cc

Issue 10080018: Don't allow sending data URLs to WebUI, unless in a ChromeOS BalloonHost. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix compile errors and crash in tests. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/site_instance_impl_unittest.cc ('k') | content/browser/web_contents/render_view_host_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/web_contents/render_view_host_manager.cc

diff --git a/content/browser/web_contents/render_view_host_manager.cc b/content/browser/web_contents/render_view_host_manager.cc

index e4c5bff9726b9ed61cb970fe6331f5812d7138ec..6d4e636961e7cab0025d0b85b7334ee4875a3793 100644

--- a/content/browser/web_contents/render_view_host_manager.cc

+++ b/content/browser/web_contents/render_view_host_manager.cc

@@ -375,8 +375,9 @@ bool RenderViewHostManager::ShouldSwapProcessesForNavigation(

if (web_ui_factory) {

if (web_ui_factory->UseWebUIForURL(browser_context, current_url)) {

// Force swap if it's not an acceptable URL for Web UI.

+ // Here, data URLs are never allowed.

if (!web_ui_factory->IsURLAcceptableForWebUI(browser_context,

- new_entry->GetURL()))

+ new_entry->GetURL(), false))

return true;

} else {

// Force swap if it's a Web UI URL.