content/browser/renderer_host/render_view_host_manager_browsertest.cc - Issue 10079023: Move notifications used only in chrome/ out of content/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/render_view_host_manager_browsertest.cc

Issue 10079023: Move notifications used only in chrome/ out of content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: six! Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/omnibox/omnibox_view_browsertest.cc ('K') | « chrome/test/base/ui_test_utils.cc ('k') | content/browser/renderer_host/resource_dispatcher_host_browsertest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/render_view_host_manager_browsertest.cc

diff --git a/content/browser/renderer_host/render_view_host_manager_browsertest.cc b/content/browser/renderer_host/render_view_host_manager_browsertest.cc

index 4035e4552f1b4cff9280fc28885aedf6894ef93b..23cb82fa360831946025d68ad10e104a999f31c0 100644

--- a/content/browser/renderer_host/render_view_host_manager_browsertest.cc

+++ b/content/browser/renderer_host/render_view_host_manager_browsertest.cc

@@ -67,9 +67,8 @@ IN_PROC_BROWSER_TEST_F(RenderViewHostManagerTest, NoScriptAccessAfterSwapOut) {

EXPECT_TRUE(orig_site_instance != NULL);

// Open a same-site link in a new tab.

- ui_test_utils::WindowedNotificationObserver new_tab_observer(

- content::NOTIFICATION_TAB_ADDED,

- content::Source<content::WebContentsDelegate>(browser()));

+ ui_test_utils::WindowedTabAddedNotificationObserver new_tab_observer((

+ content::Source<content::WebContentsDelegate>(browser())));

bool success = false;

EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",

@@ -364,9 +363,8 @@ IN_PROC_BROWSER_TEST_F(RenderViewHostManagerTest,

EXPECT_TRUE(orig_site_instance != NULL);

// Test clicking a target=foo link.

- ui_test_utils::WindowedNotificationObserver new_tab_observer(

- content::NOTIFICATION_TAB_ADDED,

- content::Source<content::WebContentsDelegate>(browser()));

+ ui_test_utils::WindowedTabAddedNotificationObserver new_tab_observer((

+ content::Source<content::WebContentsDelegate>(browser())));

bool success = false;

EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",

@@ -447,9 +445,8 @@ IN_PROC_BROWSER_TEST_F(RenderViewHostManagerTest,

EXPECT_TRUE(orig_site_instance != NULL);

// Test clicking a target=foo link.

- ui_test_utils::WindowedNotificationObserver new_tab_observer(

- content::NOTIFICATION_TAB_ADDED,

- content::Source<content::WebContentsDelegate>(browser()));

+ ui_test_utils::WindowedTabAddedNotificationObserver new_tab_observer((

+ content::Source<content::WebContentsDelegate>(browser())));

bool success = false;

EXPECT_TRUE(ui_test_utils::ExecuteJavaScriptAndExtractBool(

browser()->GetSelectedWebContents()->GetRenderViewHost(), L"",