Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc

Issue 10079023: Move notifications used only in chrome/ out of content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: six! Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
diff --git a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
index bac517ae2830b0f3909ad3899f3615de16c60e95..5c4ae812dfa966d3a28b9d5553628700550385c4 100644
--- a/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
+++ b/chrome/browser/ui/omnibox/omnibox_view_browsertest.cc
@@ -225,11 +225,12 @@ class OmniboxViewTest : public InProcessBrowserTest,
return;
content::NotificationRegistrar registrar;
- registrar.Add(this,
- (tab_count < expected_tab_count ?
- content::NOTIFICATION_TAB_PARENTED :
- content::NOTIFICATION_TAB_CLOSED),
- content::NotificationService::AllSources());
+ registrar.Add(
+ this,
+ tab_count < expected_tab_count
+ ? static_cast<int>(chrome::NOTIFICATION_TAB_PARENTED)
jam 2012/04/15 22:10:18 nit: you shouldn't need a cast here?
Avi (use Gerrit) 2012/04/16 00:09:39 It wouldn't be there if I didn't need it :) chrome
+ : static_cast<int>(content::NOTIFICATION_WEB_CONTENTS_DESTROYED),
+ content::NotificationService::AllSources());
while (!HasFailure() && browser->tab_count() != expected_tab_count)
ui_test_utils::RunMessageLoop();
@@ -371,8 +372,8 @@ class OmniboxViewTest : public InProcessBrowserTest,
const content::NotificationSource& source,
const content::NotificationDetails& details) {
switch (type) {
- case content::NOTIFICATION_TAB_CLOSED:
- case content::NOTIFICATION_TAB_PARENTED:
+ case content::NOTIFICATION_WEB_CONTENTS_DESTROYED:
+ case chrome::NOTIFICATION_TAB_PARENTED:
case chrome::NOTIFICATION_AUTOCOMPLETE_CONTROLLER_RESULT_READY:
case chrome::NOTIFICATION_BOOKMARK_MODEL_LOADED:
case chrome::NOTIFICATION_HISTORY_LOADED:
« no previous file with comments | « chrome/browser/ui/intents/web_intent_picker_controller.cc ('k') | chrome/browser/ui/tab_modal_confirm_dialog_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698