Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Unified Diff: chrome/browser/browser_keyevents_browsertest.cc

Issue 10079023: Move notifications used only in chrome/ out of content/. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: six! Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/browser_keyevents_browsertest.cc
diff --git a/chrome/browser/browser_keyevents_browsertest.cc b/chrome/browser/browser_keyevents_browsertest.cc
index edf9fa3547162d0e4be3fb0d5c1dadd0d360cb0f..5cac98598cab98596f3a7f97631b44bd0b3d329e 100644
--- a/chrome/browser/browser_keyevents_browsertest.cc
+++ b/chrome/browser/browser_keyevents_browsertest.cc
@@ -687,7 +687,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_ReservedAccelerators) {
};
ui_test_utils::WindowedNotificationObserver wait_for_new_tab(
- content::NOTIFICATION_TAB_PARENTED,
+ chrome::NOTIFICATION_TAB_PARENTED,
content::NotificationService::AllSources());
// Press Ctrl/Cmd+T, which will open a new tab. It cannot be suppressed.
@@ -701,7 +701,7 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_ReservedAccelerators) {
EXPECT_EQ(2, browser()->tab_count());
ASSERT_EQ(1, browser()->active_index());
- // Because of issue http://crbug.com/65375, switching back to the first tab
+ // Because of issue <http://crbug.com/65375>, switching back to the first tab
// may cause the focus to be grabbed by omnibox. So instead, we load our
// testing page in the newly created tab and try Cmd-W here.
ui_test_utils::NavigateToURL(browser(), url);
@@ -714,9 +714,8 @@ IN_PROC_BROWSER_TEST_F(BrowserKeyEventsTest, MAYBE_ReservedAccelerators) {
ASSERT_NO_FATAL_FAILURE(SuppressAllEvents(1, true));
ui_test_utils::WindowedNotificationObserver wait_for_tab_closed(
- content::NOTIFICATION_TAB_CLOSED,
- content::Source<NavigationController>(
- &browser()->GetWebContentsAt(1)->GetController()));
+ content::NOTIFICATION_WEB_CONTENTS_DESTROYED,
+ content::Source<content::WebContents>(browser()->GetWebContentsAt(1)));
// Press Ctrl/Cmd+W, which will close the tab.
#if defined(OS_MACOSX)

Powered by Google App Engine
This is Rietveld 408576698